Skip to content

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented May 7, 2025

Notably, pinned prelude version includes facebook/buck2-prelude@958af4f . Also, we're able to simplify our Buck versioning logic now that Buck has consistent versions across platforms (facebook/buck2#828 (comment))

[ghstack-poisoned]
@swolchok swolchok requested a review from GregoryComer as a code owner May 7, 2025 02:40
@swolchok
Copy link
Contributor Author

swolchok commented May 7, 2025

Stack from ghstack (oldest at bottom):

swolchok added a commit that referenced this pull request May 7, 2025
Notably, pinned prelude version includes facebook/buck2-prelude@958af4f


ghstack-source-id: 5837230
ghstack-comment-id: 2856851904
Pull-Request-resolved: #10742
@pytorch-bot
Copy link

pytorch-bot bot commented May 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10742

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 26f1eaf with merge base 1656854 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2025
@swolchok swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label May 7, 2025
@swolchok swolchok merged commit bf5b99a into main May 8, 2025
168 of 175 checks passed
@swolchok swolchok deleted the gh/swolchok/435/head branch May 8, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants