Skip to content

Conversation

@digantdesai
Copy link
Contributor

@digantdesai digantdesai commented May 9, 2025

Summary

  • Adds MVE version of [de]quantize_per_tensor
  • Adds basic support to link Cortex-M backend op (replacing ET quantized ops) with Arm Ethos runner
  • Use them in FVP tests for M55/M85
  • No selective build yet, the plan is to extend this such that we can have, merged_yaml with ops used my model(s) from Cortex-M-backend and Portable Lib.

Test plan

./examples/arm/run.sh --target=ethos-u85-256 --model_name=lstm --bundleio

@pytorch-bot
Copy link

pytorch-bot bot commented May 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10782

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit d75b89f with merge base b1b46ee (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 9, 2025
@digantdesai digantdesai added release notes: arm Changes to the ARM backend delegate ciflow/trunk labels May 9, 2025
Add new tests for q/dq ops using from Cortex-M backend for M55
tested using,

./examples/arm/run.sh --target=ethos-u85-256 --model_name=lstm --bundleio
@zingo zingo added the module: arm Issues related to arm backend label May 9, 2025
@digantdesai
Copy link
Contributor Author

digantdesai commented May 9, 2025

@zingo - test_sigmoid_u85_BI_add_sigmoid failure is related or flaky? I can try to reproduce locally.

Update: Landing this given I don't think we are using these q/dq ops when lowering through tester, which I can do in the follow up PRs. Also U55 tests are passing.

@digantdesai digantdesai merged commit f7c906f into main May 9, 2025
275 of 278 checks passed
@digantdesai digantdesai deleted the cortexm_mve_qdq branch May 9, 2025 16:18
@zingo
Copy link
Collaborator

zingo commented May 9, 2025

@zingo - test_sigmoid_u85_BI_add_sigmoid failure is related or flaky? I can try to reproduce locally.

Update: Landing this given I don't think we are using these q/dq ops when lowering through tester, which I can do in the follow up PRs. Also U55 tests are passing.

Unfortunately I'm out of the office a few days and can't check exact details but there is a PR where @oscarandersson8218 hope to have fixed the flakey sigmoid, and update vela that you brought into Meta for test/merge a few days ago. It will hopefully fix the flakeyness. Until it is merged i think rerun the test is the best option (or ignore it)

@zingo
Copy link
Collaborator

zingo commented May 13, 2025

This is the sigmoid fix PR mentioned: #10548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants