Skip to content

[ET-VK] Moving device capabilities check to DispatchNode and PrepackNode ctor. #10785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh/trivedivivek/85/base
Choose a base branch
from
Open

[ET-VK] Moving device capabilities check to DispatchNode and PrepackNode ctor. #10785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions backends/vulkan/runtime/graph/ops/DispatchNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ DispatchNode::DispatchNode(
spec_vars_(spec_vars),
push_constants_(push_constants) {
graph.update_descriptor_counts(shader, /*execute = */ true);
graph.context()->check_device_capabilities(shader_);
}

void DispatchNode::encode(ComputeGraph* graph) {
Expand All @@ -42,8 +43,6 @@ void DispatchNode::encode(ComputeGraph* graph) {
api::Context* const context = graph->context();
vkapi::PipelineBarrier pipeline_barrier{};

context->check_device_capabilities(shader_);

std::unique_lock<std::mutex> cmd_lock = context->dispatch_lock();

std::array<uint8_t, kMaxPushConstantSize> push_constants_data;
Expand Down
3 changes: 1 addition & 2 deletions backends/vulkan/runtime/graph/ops/PrepackNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ PrepackNode::PrepackNode(
push_constants_(push_constants) {
graph.update_descriptor_counts(shader, /*execute = */ false);
graph.update_descriptor_counts(noop_shader_, /*execute = */ false);
graph.context()->check_device_capabilities(shader_);
}

api::StagingBuffer PrepackNode::create_staging_buffer(ComputeGraph* graph) {
Expand All @@ -70,8 +71,6 @@ api::StagingBuffer PrepackNode::create_staging_buffer(ComputeGraph* graph) {
void PrepackNode::encode(ComputeGraph* graph) {
api::Context* const context = graph->context();

context->check_device_capabilities(shader_);

vTensorPtr packed = graph->get_tensor(packed_);
api::StagingBuffer staging = create_staging_buffer(graph);

Expand Down
Loading