Make a separate target for kernel utils #10788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10788
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 4675d97 with merge base 6e959be ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
added
the
release notes: build
kirklandsign
requested review from
JacobSzwejbka,
iseeyuan,
jackzhxng,
larryliu0820,
manuelcandales and
swolchok
as code owners
JacobSzwejbka
approved these changes
May 12, 2025
|
|
||
| [targets.kernels_util_all_deps] | ||
| buck_targets = [ | ||
| "//kernels/portable/cpu/util:all_deps", |
Contributor
There was a problem hiding this comment.
if its used by other kernels can we move it out of portable/
Contributor
Author
There was a problem hiding this comment.
I tried. So many things can be broken, so I wouldn't bother right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's built into portable kernels only. Other kernels used it, and the runner must include portable kernel to avoid undefined symbols. We need to split these utils out. A fix for #10677 without BC breaking.