Skip to content

Rename "topic: not user facing" #10791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025
Merged

Rename "topic: not user facing" #10791

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbf84d2
Rename "topic: not user facing"
jackzhxng May 9, 2025
bac7a2d
Update on "Rename "topic: not user facing""
jackzhxng May 12, 2025
636fd66
Update on "Rename "topic: not user facing""
jackzhxng May 12, 2025
3525302
Update on "Rename "topic: not user facing""
jackzhxng May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/scripts/label_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
LABEL_ERR_MSG = f"""# {LABEL_ERR_MSG_TITLE}
If your changes are user facing and intended to be a part of release notes, please use a label starting with `release notes:`.

If not, please add the `release notes: n/a (exclude)` label.
If not, please add the `release notes: none` label.

To add a label, you can comment to pytorchbot, for example
`@pytorchbot label "release notes: n/a (exclude)"`
`@pytorchbot label "release notes: none"`

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.
Expand Down Expand Up @@ -115,7 +115,7 @@ def has_required_labels(pr: "GitHubPR") -> bool:
pr_labels = pr.get_labels()
# Check if PR is not user facing
is_not_user_facing_pr = any(
label.strip() == "release notes: n/a (exclude)" for label in pr_labels
label.strip() == "release notes: none" for label in pr_labels
)
return is_not_user_facing_pr or any(
label.strip() in get_release_notes_labels(pr.org, pr.project)
Expand Down
Loading