Skip to content

Conversation

@metascroy
Copy link
Contributor

Adds new "common issues" section to CoreML backend

@metascroy metascroy requested a review from mergennachin as a code owner May 12, 2025 17:25
@pytorch-bot
Copy link

pytorch-bot bot commented May 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10816

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 19 Pending

As of commit a538511 with merge base b11807c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2025
@metascroy metascroy requested review from GregoryComer and YifanShenSZ and removed request for mergennachin May 12, 2025 17:25
Copy link
Member

@GregoryComer GregoryComer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. In the long-term, is it feasible for us to transform the dtypes in the delegate when lowering to avoid needing a workaround?

@metascroy
Copy link
Contributor Author

metascroy commented May 12, 2025

Thanks for adding this. In the long-term, is it feasible for us to transform the dtypes in the delegate when lowering to avoid needing a workaround?

In discord I discussed changing coremltools to do this (but I don't think we should do it in ET).

@metascroy metascroy merged commit 500842a into main May 12, 2025
86 of 88 checks passed
@metascroy metascroy deleted the metascroy-patch-2 branch May 12, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants