Skip to content

Conversation

@per
Copy link
Collaborator

@per per commented May 13, 2025

Summary

Make is_U55_subset part of the base TOSA specification class as the
subset is not tied to a specific specification. Using the
is_U55_subset attribute the supported checks for U55 subset are
updated to catch TOSA 1.0 as well.

Test plan

Tested on internal and external CI.

cc @digantdesai @freddan80 @zingo @oscarandersson8218

@per per requested a review from digantdesai as a code owner May 13, 2025 10:48
@per per added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing release notes: arm Changes to the ARM backend delegate labels May 13, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented May 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10849

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 20 New Failures, 5 Unrelated Failures

As of commit e25f665 with merge base a21022c (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2025
@per per requested a review from zingo May 13, 2025 10:49
per added 2 commits May 14, 2025 08:53
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I54cce2c9af9aebf95dbc66b93ae42c3222cb057f
Make is_U55_subset part of the base TOSA specification class as the
subset is not tied to a specific specification. Using the
is_U55_subset attribute the supported checks for U55 subset are
updated to catch TOSA 1.0 as well.

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: Ieb025f907cc4e7e9856a186d8b4dba7d03cb7e96
@per per force-pushed the tosa_1_u55_subset branch from cf310d4 to e25f665 Compare May 14, 2025 06:53
@zingo
Copy link
Collaborator

zingo commented May 14, 2025

Test fails unrelated fails on other PRs as well

@zingo zingo merged commit f785386 into pytorch:main May 14, 2025
157 of 182 checks passed
@per per deleted the tosa_1_u55_subset branch May 15, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants