Skip to content

Conversation

@AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented May 13, 2025

  • Adds ./src/ to MYPYPATH to find imports for editable install
  • Make --revision point to the commit before the commit to be linted. Since lintrunner compares files diffing between --revision and HEAD, pointing it to the the latest commit (== HEAD) results in no files being linted.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Adds ./src/ to MYPYPATH to find imports for editable install
- Make --revision point to the commit before the commit to be linted.
  Since lintrunner compares files diffing between --revision and HEAD,
  pointing it to the the latest commit (== HEAD) results in no files
  being linted.

Signed-off-by: Adrian Lundell <[email protected]>
Change-Id: Ia7ce8f02e1ae526dce91758bc267cd78f1f40ee6
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing release notes: none Do not include this in the release notes labels May 13, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented May 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10850

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit cc16926 with merge base dcd25eb (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2025
@AdrianLundell AdrianLundell requested a review from zingo May 13, 2025 13:47
@AdrianLundell
Copy link
Collaborator Author

Unrelated error trunk / test-models-linux-aarch64 (linear, portable, linux.arm64.2xlarge) / linux-job (gh): "error: incomplete-download"

@zingo zingo merged commit e71b3aa into pytorch:main May 13, 2025
181 of 185 checks passed
@AdrianLundell AdrianLundell deleted the change-1039417 branch September 4, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants