Add pass to convert kwargs to args + populate optional args. #10857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10857
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 15514d3 with merge base 24789c8 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74510388 |
zonglinpeng
approved these changes
May 14, 2025
hsharma35
force-pushed
the
export-D74510388
branch
from
28a6056 to
1f5ab1c
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
May 14, 2025
…#10857) Summary: Adds a pass to convert kwargs to args and populate optional args. Reviewed By: zonglinpeng Differential Revision: D74510388
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74510388 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
May 14, 2025
…#10857) Summary: Pull Request resolved: pytorch#10857 Adds a pass to convert kwargs to args and populate optional args. Reviewed By: zonglinpeng Differential Revision: D74510388
hsharma35
force-pushed
the
export-D74510388
branch
from
1f5ab1c to
5b41f97
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
May 15, 2025
…#10857) Summary: Adds a pass to convert kwargs to args and populate optional args. Reviewed By: zonglinpeng Differential Revision: D74510388
hsharma35
force-pushed
the
export-D74510388
branch
from
5b41f97 to
246c300
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74510388 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
May 15, 2025
…#10857) Summary: Pull Request resolved: pytorch#10857 Adds a pass to convert kwargs to args and populate optional args. Reviewed By: zonglinpeng Differential Revision: D74510388
hsharma35
force-pushed
the
export-D74510388
branch
from
246c300 to
7bf3747
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
May 15, 2025
…#10857) Summary: Adds a pass to convert kwargs to args and populate optional args. For example: ``` # Before: slice_copy.Tensor(x, 1, end=3) # dim = 1, start is optional = none, end is a kwarg = 3 # After: slice_copy.Tensor(x, 1, None, 3, 1) ``` Reviewed By: zonglinpeng Differential Revision: D74510388
hsharma35
force-pushed
the
export-D74510388
branch
from
7bf3747 to
770a26a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74510388 |
hsharma35
force-pushed
the
export-D74510388
branch
from
770a26a to
f0771b2
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
May 15, 2025
…#10857) Summary: Adds a pass to convert kwargs to args and populate optional args. For example: ``` # Before: slice_copy.Tensor(x, 1, end=3) # dim = 1, start is optional = none, end is a kwarg = 3 # After: slice_copy.Tensor(x, 1, None, 3, 1) ``` Reviewed By: zonglinpeng Differential Revision: D74510388
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74510388 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
May 15, 2025
…#10857) Summary: Pull Request resolved: pytorch#10857 Adds a pass to convert kwargs to args and populate optional args. For example: ``` # Before: slice_copy.Tensor(x, 1, end=3) # dim = 1, start is optional = none, end is a kwarg = 3 # After: slice_copy.Tensor(x, 1, None, 3, 1) ``` Reviewed By: zonglinpeng Differential Revision: D74510388
hsharma35
force-pushed
the
export-D74510388
branch
from
f0771b2 to
672e778
Compare
Summary: Add call_getitem support in graph builder. Differential Revision: D74817590
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
May 15, 2025
…#10857) Summary: Adds a pass to convert kwargs to args and populate optional args. For example: ``` # Before: slice_copy.Tensor(x, 1, end=3) # dim = 1, start is optional = none, end is a kwarg = 3 # After: slice_copy.Tensor(x, 1, None, 3, 1) ``` Reviewed By: zonglinpeng Differential Revision: D74510388
hsharma35
force-pushed
the
export-D74510388
branch
from
672e778 to
f772a62
Compare
…#10857) Summary: Pull Request resolved: pytorch#10857 Adds a pass to convert kwargs to args and populate optional args. For example: ``` # Before: slice_copy.Tensor(x, 1, end=3) # dim = 1, start is optional = none, end is a kwarg = 3 # After: slice_copy.Tensor(x, 1, None, 3, 1) ``` Reviewed By: zonglinpeng Differential Revision: D74510388
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74510388 |
hsharma35
force-pushed
the
export-D74510388
branch
from
f772a62 to
15514d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds a pass to convert kwargs to args and populate optional args.
Differential Revision: D74510388