Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

Summary

This PR solves the broken example in devtool workflow page.

@pytorch-bot
Copy link

pytorch-bot bot commented May 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10885

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures

As of commit 77cbcab with merge base e7d39c2 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2025
@Gasoonjia
Copy link
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label May 15, 2025
Comment on lines 204 to 215
# sphinx_gallery_start_ignore
# Display the actural inspector tabular table image
import matplotlib.image as mpimg
import matplotlib.pyplot as plt

# Load and display the image
img = mpimg.imread("tabular_result.png")
fig, ax = plt.subplots(figsize=(8, 6), dpi=150) # Adjust figsize and dpi as needed
ax.imshow(img)
ax.axis("off") # Hide axes
plt.show()
# sphinx_gallery_end_ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this with:

####################################
#
# Here is an example output:
#
# .. image:: ../_static/img/tabular_result.png

Comment on lines 216 to 219

# sphinx_gallery_start_ignore
inspector_patch.stop()
inspector_patch_print.stop()
Copy link
Contributor

@svekars svekars May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 217 - 219 cause the Out: False.
I don't know if they are needed. If you remove the the example seems to still work but the extraneous output disappears.
Assigning return value to a ('_') variable should hide the output

@Gasoonjia Gasoonjia force-pushed the solving-broken-devtool-workflow branch from dc39d96 to 77cbcab Compare May 19, 2025 20:45
@mergennachin
Copy link
Contributor

Why are including so many things in this PR??

.so files should be checked in, data/bin shouldn't be, include/executorch shouldn't be checked in.

Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Sep 1, 2025
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes stale PRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants