-
Notifications
You must be signed in to change notification settings - Fork 749
solve broken devtool workflow #10885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10885
Note: Links to docs will display an error until the docs builds have been completed. ❌ 8 New FailuresAs of commit 77cbcab with merge base e7d39c2 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "release notes: none" |
| # sphinx_gallery_start_ignore | ||
| # Display the actural inspector tabular table image | ||
| import matplotlib.image as mpimg | ||
| import matplotlib.pyplot as plt | ||
|
|
||
| # Load and display the image | ||
| img = mpimg.imread("tabular_result.png") | ||
| fig, ax = plt.subplots(figsize=(8, 6), dpi=150) # Adjust figsize and dpi as needed | ||
| ax.imshow(img) | ||
| ax.axis("off") # Hide axes | ||
| plt.show() | ||
| # sphinx_gallery_end_ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this with:
####################################
#
# Here is an example output:
#
# .. image:: ../_static/img/tabular_result.png
|
|
||
| # sphinx_gallery_start_ignore | ||
| inspector_patch.stop() | ||
| inspector_patch_print.stop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lines 217 - 219 cause the Out: False.
I don't know if they are needed. If you remove the the example seems to still work but the extraneous output disappears.
Assigning return value to a ('_') variable should hide the output
This reverts commit 18d7ef3.
dc39d96 to
77cbcab
Compare
|
Why are including so many things in this PR?? .so files should be checked in, data/bin shouldn't be, include/executorch shouldn't be checked in. |
mergennachin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Summary
This PR solves the broken example in devtool workflow page.