-
Notifications
You must be signed in to change notification settings - Fork 752
Arm backend: Do not delegate casting to FP dtypes with BI profile #10906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Do not delegate casting to FP dtypes with BI profile #10906
Conversation
- Casting to floating-point dtypes should be rejected for delegation. Class ToCopySupported should guarantee this. However, the shallow copy used in func _merge_supported_types will modify the dict SUPPORTED_INT_TYPES unintentionally, merging the dict SUPPORTED_FLOAT_TYPES into SUPPORTED_INT_TYPES. Therefore, casting to floating-point dtypes can also pass the check under BI profile. - Fix it by using deepcopy. - Add unittest in test_to_copy.py to check the castings to FP dtypes are not delegated. Change-Id: Ia5fce0c0284aa35fcd5a482fe11985573a00db8b Signed-off-by: Yufeng Shi <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10906
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Pending, 1 Unrelated FailureAs of commit b78b885 with merge base d069d65 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Unstable/Flaky tests: -pull / unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job (pull_request) -trunk / test-arm-backend (test_pytest_ops_ethosu_fvp) / linux-job (push) |
|
I rebased it to trigger a test re-run to see if we can get the Arm tests green |
|
That worked, Arm tests are OK and other are as you mention unrelated |
Change-Id: Ia5fce0c0284aa35fcd5a482fe11985573a00db8b
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218