Skip to content

Make test_no_replace_quant_permute_dequant_with_requantize use GraphBuilder. #10927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
May 19, 2025
Merged

Make test_no_replace_quant_permute_dequant_with_requantize use GraphBuilder. #10927

facebook-github-bot merged 1 commit into from
May 19, 2025

Conversation

@eigen-k
Copy link
Contributor

@eigen-k eigen-k commented May 15, 2025

Summary: Use GraphBuilder to create the model for unit testing.

Differential Revision: D74842294

@eigen-k eigen-k requested a review from tarun292 as a code owner May 15, 2025 22:29
@pytorch-bot
Copy link

pytorch-bot bot commented May 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10927

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7c33690 with merge base de72d65 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 15, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 15, 2025

This pull request was exported from Phabricator. Differential Revision: D74842294

eigen-k added a commit to eigen-k/executorch that referenced this pull request May 16, 2025
@eigen-k @facebook-github-bot
Make test_no_replace_quant_permute_dequant_with_requantize use GraphB…
df3c697 
…uilder. (pytorch#10927)

Summary:

Use GraphBuilder to create the model for unit testing.

Differential Revision: D74842294
@eigen-k eigen-k force-pushed the export-D74842294 branch from 3dabeaf to df3c697 Compare May 16, 2025 17:24
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 16, 2025

This pull request was exported from Phabricator. Differential Revision: D74842294

@eigen-k eigen-k force-pushed the export-D74842294 branch from df3c697 to 45746db Compare May 16, 2025 17:55
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 16, 2025

This pull request was exported from Phabricator. Differential Revision: D74842294

@eigen-k eigen-k added the release notes: none Do not include this in the release notes label May 16, 2025
mcremon-meta
mcremon-meta approved these changes May 16, 2025
View reviewed changes
backends/cadence/aot/tests/test_fusion_ops_passes.py
)
builder.output(dequant)
graph_module = FuseQuantDequantToRequantizePass(
force_quant_dequant_fusion=False
Copy link
Contributor

@mcremon-meta mcremon-meta May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to add the flag here?

Copy link
Contributor Author

@eigen-k eigen-k May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the parameter defaults to False, I chose to set it explicitly to False to avoid any ambiguity, given that the adjacent test has it set to True. Does it seem redundant?

Copy link
Contributor

@mcremon-meta mcremon-meta May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no issue with it, was just wondering if there was a reason, but I noticed the other test being True after this review :)

@eigen-k eigen-k force-pushed the export-D74842294 branch from 45746db to df5b1ac Compare May 19, 2025 16:35
eigen-k added a commit to eigen-k/executorch that referenced this pull request May 19, 2025
@eigen-k @facebook-github-bot
Make test_no_replace_quant_permute_dequant_with_requantize use GraphB…
df5b1ac 
…uilder. (pytorch#10927)

Summary:

Use GraphBuilder to create the model for unit testing.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D74842294
@eigen-k @facebook-github-bot
Make test_no_replace_quant_permute_dequant_with_requantize use GraphB…
7c33690 
…uilder. (pytorch#10927)

Summary:
Pull Request resolved: pytorch#10927

Use GraphBuilder to create the model for unit testing.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D74842294
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 19, 2025

This pull request was exported from Phabricator. Differential Revision: D74842294

@eigen-k eigen-k force-pushed the export-D74842294 branch from df5b1ac to 7c33690 Compare May 19, 2025 16:39
@facebook-github-bot facebook-github-bot merged commit 3032398 into pytorch:main May 19, 2025
90 checks passed
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request May 19, 2025
@eigen-k @hinriksnaer
Make test_no_replace_quant_permute_dequant_with_requantize use GraphB…
f9d17fa 
…uilder.

Differential Revision: D74842294

Pull Request resolved: pytorch#10927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcremon-meta mcremon-meta mcremon-meta approved these changes

@zonglinpeng zonglinpeng zonglinpeng approved these changes

@tarun292 tarun292 Awaiting requested review from tarun292

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eigen-k @facebook-github-bot @zonglinpeng @mcremon-meta