Make test_replace_quant_view_dequant_with_requantize use GraphBuilder. #10928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10928
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 19a9179 with merge base de72d65 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74843628 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 16, 2025
pytorch#10928) Summary: Use GraphBuilder to create the model for unit testing. Differential Revision: D74843628
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 16, 2025
pytorch#10928) Summary: Use GraphBuilder to create the model for unit testing. Differential Revision: D74843628
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74843628 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74843628 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 16, 2025
pytorch#10928) Summary: Pull Request resolved: pytorch#10928 Use GraphBuilder to create the model for unit testing. Differential Revision: D74843628
mcremon-meta
approved these changes
May 16, 2025
| ) | ||
| builder.output(dequant) | ||
| graph_module = FuseQuantDequantToRequantizePass()( | ||
| builder.get_graph_module() |
Contributor
There was a problem hiding this comment.
Nit: same as the other PR, we can use a variable for readability
zonglinpeng
approved these changes
May 17, 2025
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 19, 2025
pytorch#10928) Summary: Use GraphBuilder to create the model for unit testing. Reviewed By: zonglinpeng, mcremon-meta Differential Revision: D74843628
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 19, 2025
pytorch#10928) Summary: Use GraphBuilder to create the model for unit testing. Reviewed By: zonglinpeng, mcremon-meta Differential Revision: D74843628
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74843628 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
May 19, 2025
pytorch#10928) Summary: Pull Request resolved: pytorch#10928 Use GraphBuilder to create the model for unit testing. Reviewed By: zonglinpeng, mcremon-meta Differential Revision: D74843628
pytorch#10928) Summary: Pull Request resolved: pytorch#10928 Use GraphBuilder to create the model for unit testing. Reviewed By: zonglinpeng, mcremon-meta Differential Revision: D74843628
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74843628 |
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
May 19, 2025
Differential Revision: D74843628 Pull Request resolved: pytorch#10928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use GraphBuilder to create the model for unit testing.
Differential Revision: D74843628