Create a pybind preset #10932
Merged
Create a pybind preset #10932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathu
added
module: build/install
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10932
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 0b0a91e with merge base 5c6d4e5 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jathu
force-pushed
the
jathu/preset--pybind-macos
branch
5 times, most recently
from
a978c01 to
0346f80
Compare
jathu
force-pushed
the
jathu/preset--pybind-macos
branch
4 times, most recently
from
ce4776f to
de1fc49
Compare
jathu
force-pushed
the
jathu/preset--pybind-macos
branch
from
de1fc49 to
0b0a91e
Compare
larryliu0820
approved these changes
May 16, 2025
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
May 19, 2025
### Summary In this diff we create a `pybind` preset that is copied with configurations from [setup.py](https://github.com/pytorch/executorch/blob/7175ca420dc5a173f8635da976457bf6f17bbbc1/setup.py). In upcoming diffs, we will completely gut setup.py and point directly to this preset. ### Test plan ``` $ cmake --list-presets Available configure presets: "macos-arm64" - Build everything buildable on macOS arm64 "pybind" - Build pybindings exported in the wheel ``` ``` $ cmake --preset pybind && cmake --build cmake-out --parallel ``` cc @larryliu0820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this diff we create a
pybindpreset that is copied with configurations from setup.py. In upcoming diffs, we will completely gut setup.py and point directly to this preset.Test plan
cc @larryliu0820