Skip to content

Arm backend: Add validation steps to op_neg #10942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zingo merged 1 commit into from
May 16, 2025
Merged

Arm backend: Add validation steps to op_neg #10942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions backends/arm/operators/op_neg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@
NodeVisitor,
register_node_visitor,
)

from executorch.backends.arm.operators.operator_validation_utils import (
validate_num_inputs,
validate_same_dtype,
)
from executorch.backends.arm.tosa_mapping import TosaArg


Expand Down Expand Up @@ -60,14 +63,12 @@ def define_node(
ts.DType.FP32,
}

validate_num_inputs(self.target, inputs, 1)
validate_same_dtype(self.target, [*inputs, output])

if inputs[0].dtype not in supported_dtypes:
raise ValueError(f"Unsupported dtype for NEGATE: {inputs[0].dtype}")

if inputs[0].dtype != output.dtype:
raise ValueError(
"All inputs and output need same dtype."
f"Got {inputs[0].dtype=}, {output.dtype=}"
)
input_zp, output_zp = get_negate_zero_points(
node, inputs[0].dtype == ts.DType.INT8
)
Expand Down Expand Up @@ -109,14 +110,12 @@ def define_node(
ts.DType.FP32,
}

validate_num_inputs(self.target, inputs, 1)
validate_same_dtype(self.target, [*inputs, output])

if inputs[0].dtype not in supported_dtypes:
raise ValueError(f"Unsupported dtype for NEGATE: {inputs[0].dtype}")

if inputs[0].dtype != output.dtype:
raise ValueError(
"All inputs and output need same dtype."
f"Got {inputs[0].dtype=}, {output.dtype=}"
)
input_zp, output_zp = get_negate_zero_points(
node, inputs[0].dtype == ts.DType.INT8
)
Expand Down
Loading