Use "pybind" preset when building a wheel #10951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathu
added
module: build/install
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10951
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit b9434fa with merge base 9c1186f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jathu
force-pushed
the
jathu/use-pybind-preset
branch
24 times, most recently
from
05c5365 to
48acde6
Compare
jathu
force-pushed
the
jathu/use-pybind-preset
branch
15 times, most recently
from
174fab9 to
98a3cdf
Compare
jathu
force-pushed
the
jathu/use-pybind-preset
branch
from
98a3cdf to
b9434fa
Compare
kirklandsign
approved these changes
May 20, 2025
larryliu0820
approved these changes
May 20, 2025
|
|
||
| # Build the package | ||
| pip install . --no-build-isolation | ||
| ./install_executorch.sh |
Comment on lines
+693
to
+703
| subprocess.run( | ||
| [ | ||
| "cmake", | ||
| *cmake_configuration_args, | ||
| "--preset", | ||
| "pybind", | ||
| "-B", | ||
| cmake_cache_dir, | ||
| ], | ||
| check=True, | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we have presets for pybind, lets use that and eliminate the need to set cmake configurations in
setup.py. Moreover, we now stop relying on defaults and fully rely on the cmake configurations. This includes relying onCMakeCache.txtto determine what features are enabled to determine what extensions to copy.Test plan
CI +
cc @larryliu0820