Skip to content

Conversation

@leafs1
Copy link
Contributor

@leafs1 leafs1 commented May 16, 2025

Summary

Support log in XNNPACK backend

Test plan

Wrote test cases to see if appropriate xnnpack log was called

@pytorch-bot
Copy link

pytorch-bot bot commented May 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10952

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 9 Pending

As of commit 8e4f7af with merge base de72d65 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 16, 2025
@leafs1
Copy link
Contributor Author

leafs1 commented May 16, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label May 16, 2025
@GregoryComer
Copy link
Member

Looks great - that was fast. @leafs1 can you run the lintrunner to format the code? This will fix the Lint failure job. There should be instructions on the setup under contributing.md.

@mcr229 Can you take a look when you have time? Thanks.

Copy link
Contributor

@mcr229 mcr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leafs1 leafs1 merged commit 78227f0 into pytorch:main May 19, 2025
88 checks passed
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request May 19, 2025
### Summary
Support log in XNNPACK backend

### Test plan
Wrote test cases to see if appropriate xnnpack log was called
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants