Skip to content

Remove CMAKE_OSX_DEPLOYMENT_TARGET from executorchcoreml #11062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jathu merged 2 commits into from
May 22, 2025
Merged

Remove CMAKE_OSX_DEPLOYMENT_TARGET from executorchcoreml #11062

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d93102
dont specify target
jathu May 22, 2025
5fa6ad4
Merge branch 'main' into jathu/no-osx-dt
jathu May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions backends/apple/coreml/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ endif()

option(COREML_BUILD_EXECUTOR_RUNNER "Build CoreML executor runner." OFF)

set(CMAKE_OSX_DEPLOYMENT_TARGET 10.15)

# inmemoryfs sources
set(INMEMORYFS_SOURCES
runtime/inmemoryfs/inmemory_filesystem.cpp
Expand Down Expand Up @@ -240,7 +238,6 @@ if(EXECUTORCH_BUILD_COREML AND EXECUTORCH_BUILD_PYBIND)

pybind11_add_module(executorchcoreml SHARED runtime/inmemoryfs/inmemory_filesystem_py.cpp)

target_compile_options(executorchcoreml PRIVATE -mmacosx-version-min=${CMAKE_OSX_DEPLOYMENT_TARGET})
if(CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")
target_compile_options(executorchcoreml PRIVATE -g)
endif()
Expand Down
Loading