- 
                Notifications
    You must be signed in to change notification settings 
- Fork 706
Convert args to LlmConfig #11081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            facebook-github-bot
  merged 19 commits into
  gh/jackzhxng/12/base
from
gh/jackzhxng/12/head
  
      
      
   
  Jun 10, 2025 
      
    
  
     Merged
                    Convert args to LlmConfig #11081
Changes from all commits
      Commits
    
    
            Show all changes
          
          
            19 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      aed7c50
              
                Convert args to LlmConfig
              
              
                jackzhxng 749f3a5
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng 65aa3b0
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng 8acf68f
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng d230d0b
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng 1644117
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng 5adb6d2
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng 0cf4fd3
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng 3885680
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng 5de72ee
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng cb1a6c3
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng cd0d188
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng 216e231
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng 5138ebc
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng 5462ab3
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng 7f8f4cf
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng 39b59cb
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng 0a00549
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng c5b956c
              
                Update on "Convert args to LlmConfig"
              
              
                jackzhxng File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should definitely vet what of those original args are worth keeping