Skip to content

Conversation

@jathu
Copy link
Contributor

@jathu jathu commented May 23, 2025

Summary

  • Use the Apple presets to build the frameworks
  • Make the script build without options by default. If people want to turn off features, they can use CMAKE_ARGS

Test plan

CI +

$ scripts/build_apple_frameworks.sh
$ scripts/build_apple_frameworks.sh --portable --coreml

@pytorch-bot
Copy link

pytorch-bot bot commented May 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11115

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 76dc199 with merge base 8b95d9e (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2025
@jathu jathu temporarily deployed to upload-benchmark-results May 23, 2025 22:23 — with GitHub Actions Inactive
@jathu jathu force-pushed the jathu/apple-use-preset branch from fd4bdcd to 0fbe26c Compare May 23, 2025 22:32
@jathu jathu added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label May 23, 2025
@jathu jathu temporarily deployed to upload-benchmark-results May 23, 2025 23:11 — with GitHub Actions Inactive
@jathu jathu force-pushed the jathu/apple-use-preset branch from 0fbe26c to e7bd5e8 Compare May 23, 2025 23:13
@jathu jathu marked this pull request as ready for review May 23, 2025 23:14
@jathu jathu temporarily deployed to upload-benchmark-results May 23, 2025 23:49 — with GitHub Actions Inactive
@jathu jathu force-pushed the jathu/apple-use-preset branch from e7bd5e8 to aa07434 Compare May 26, 2025 19:07
@jathu jathu temporarily deployed to upload-benchmark-results May 26, 2025 19:42 — with GitHub Actions Inactive
@jathu jathu force-pushed the jathu/apple-use-preset branch from aa07434 to 0292616 Compare May 26, 2025 23:02
@jathu jathu temporarily deployed to upload-benchmark-results May 26, 2025 23:51 — with GitHub Actions Inactive
@jathu jathu force-pushed the jathu/apple-use-preset branch from 0292616 to 717b504 Compare May 27, 2025 23:03
@jathu jathu force-pushed the jathu/apple-use-preset branch from 717b504 to 76dc199 Compare May 27, 2025 23:05
@jathu jathu temporarily deployed to upload-benchmark-results May 27, 2025 23:53 — with GitHub Actions Inactive
@jathu jathu merged commit bfdbd5b into main May 28, 2025
110 of 113 checks passed
@jathu jathu deleted the jathu/apple-use-preset branch May 28, 2025 00:45
@shoumikhin
Copy link
Contributor

Update using-executorch-ios.md too?

jathu added a commit that referenced this pull request May 28, 2025
…1174)

### Summary
After #11115, we don't need to
pass all the flags.

### Test plan

```
rg "build_apple_frameworks" -t markdown
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants