Skip to content

[ET-VK] Storing positions in uint16 to instead of int in conv2d pw shader. #11138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2025
Merged

[ET-VK] Storing positions in uint16 to instead of int in conv2d pw shader. #11138

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d95d3c4
[ET-VK] Storing positions in uint16 to instead of int in conv2d pw sh…
trivedivivek May 27, 2025
b57446e
Update on "[ET-VK] Storing positions in uint16 to instead of int in c…
trivedivivek May 27, 2025
9cb6365
Update on "[ET-VK] Storing positions in uint16 to instead of int in c…
trivedivivek May 27, 2025
03ec17e
Update on "[ET-VK] Storing positions in uint16 to instead of int in c…
trivedivivek May 28, 2025
8983705
Update on "[ET-VK] Storing positions in uint16 to instead of int in c…
trivedivivek May 28, 2025
f547b99
Update on "[ET-VK] Storing positions in uint16 to instead of int in c…
trivedivivek May 28, 2025
3c06108
Update on "[ET-VK] Storing positions in uint16 to instead of int in c…
trivedivivek May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions backends/vulkan/runtime/graph/ops/glsl/conv2d_pw_s1p0.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@

#version 450 core

#extension GL_EXT_shader_explicit_arithmetic_types_int16 : require

#define PRECISION ${PRECISION}

#define VEC4_T ${texel_type(DTYPE)}

#define TILE_SIZE_X ${TILE_SIZE_X}
#define TILE_SIZE_Y ${TILE_SIZE_Y}
#define TILE_SIZE_X uint16_t(${TILE_SIZE_X})
#define TILE_SIZE_Y uint16_t(${TILE_SIZE_Y})

#define op(X, A, B) ${OPERATOR}

Expand Down Expand Up @@ -63,11 +65,11 @@ void main() {
// +--------+--------+
// | pos[2] | pos[3] |
// +--------+--------+
int pos[TILE_SIZE_X * TILE_SIZE_Y * 2];
for (int y = 0, i = 0; y < TILE_SIZE_Y; ++y) {
for (int x = 0; x < TILE_SIZE_X; ++x) {
pos[i * 2] = out_pos[0] * TILE_SIZE_X + x;
pos[i * 2 + 1] = out_pos[1] * TILE_SIZE_Y + y;
uint16_t pos[TILE_SIZE_X * TILE_SIZE_Y * 2];
for (uint16_t y = uint16_t(0), i = uint16_t(0); y < TILE_SIZE_Y; ++y) {
for (uint16_t x = uint16_t(0); x < TILE_SIZE_X; ++x) {
pos[i * 2] = uint16_t(out_pos[0]) * TILE_SIZE_X + x;
pos[i * 2 + 1] = uint16_t(out_pos[1]) * TILE_SIZE_Y + y;
i++;
}
}
Expand Down
Loading