Skip to content

[ET-VK] Reducing precision of some in members in conv2d pw to improved performance. #11192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 29, 2025
Merged

[ET-VK] Reducing precision of some in members in conv2d pw to improved performance. #11192

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cb69a5b
[ET-VK] De vectorise conv2d pw shader to improve perf.
trivedivivek May 28, 2025
83ad3d3
[ET-VK] Remove the use of shared memory in conv2d pw to improve perf.
trivedivivek May 28, 2025
843f7d7
[ET-VK] Tuning conv 2d pw op tile size to improve perf.
trivedivivek May 28, 2025
c4780f3
[ET-VK] Minor tuning for conv2d pw op to improve performance.
trivedivivek May 28, 2025
8b3eba7
[ET-VK] De vectorise positions in conv2d pw shader to improve perf.
trivedivivek May 28, 2025
7348101
[ET-VK] Minor unroll tuning to improve conv2d pw perf.
trivedivivek May 28, 2025
e275147
[ET-VK] Tuning local workgroup size calculation for conv2d pw to impr…
trivedivivek May 28, 2025
fab78a4
[ET-VK] De vectorise all vectors in conv2d pw shader to improve perf.
trivedivivek May 28, 2025
a5ac056
[ET-VK] Creating specialized version of conv2d pw shader for X and Y …
trivedivivek May 28, 2025
b1dfb5a
[ET-VK] Storing positions in uint16 to instead of int in conv2d pw sh…
trivedivivek May 28, 2025
9d7ead2
[ET-VK] Reducing precision of some in members in conv2d pw to improve…
trivedivivek May 28, 2025
9d95ea9
Merge branch 'main' into gh/trivedivivek/99/orig
trivedivivek May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions backends/vulkan/runtime/graph/ops/glsl/conv2d_pw_s1p0.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,13 @@ layout(local_size_x_id = 0, local_size_y_id = 1, local_size_z_id = 2) in;
void main() {
const int out_limits_scaled[2] = {out_limits.x + (TILE_SIZE_X - 1) * TILE_SIZE_X, out_limits.y + (TILE_SIZE_Y - 1) * TILE_SIZE_Y};

const int div_by_x = int(gl_GlobalInvocationID.x / out_limits_scaled[0]);
const int out_pos[3] = {int(gl_GlobalInvocationID.x % out_limits_scaled[0]), div_by_x, int(gl_GlobalInvocationID.y)};
const uint16_t div_by_x = uint16_t(gl_GlobalInvocationID.x / out_limits_scaled[0]);
const uint16_t out_pos_xy[2] = {uint16_t(gl_GlobalInvocationID.x % out_limits_scaled[0]), div_by_x};
const int out_pos_z = int(gl_GlobalInvocationID.y);

// If the top left position is out of bounds, then this invocation will have
// no work to do.
if (out_pos[1] >= out_limits_scaled[1] || out_pos[2] >= out_limits.z) {
if (out_pos_xy[1] >= out_limits_scaled[1] || out_pos_z >= out_limits.z) {
return;
}

Expand All @@ -68,8 +69,8 @@ void main() {
uint16_t pos[TILE_SIZE_X * TILE_SIZE_Y * 2];
for (uint16_t y = uint16_t(0), i = uint16_t(0); y < TILE_SIZE_Y; ++y) {
for (uint16_t x = uint16_t(0); x < TILE_SIZE_X; ++x) {
pos[i * 2] = uint16_t(out_pos[0]) * TILE_SIZE_X + x;
pos[i * 2 + 1] = uint16_t(out_pos[1]) * TILE_SIZE_Y + y;
pos[i * 2] = out_pos_xy[0] * TILE_SIZE_X + x;
pos[i * 2 + 1] = out_pos_xy[1] * TILE_SIZE_Y + y;
i++;
}
}
Expand All @@ -78,7 +79,7 @@ void main() {
// Tuple of consecutive 4 elements represents a single output texel.
float sum[TILE_SIZE_X * TILE_SIZE_Y * 4];

const vec4 bias = texelFetch(t_bias, ivec2(out_pos[2], 0), 0);
const vec4 bias = texelFetch(t_bias, ivec2(out_pos_z, 0), 0);

// Initialize the output array with the bias value
for (int i = 0; i < TILE_SIZE_X * TILE_SIZE_Y * 4; i += 4) {
Expand All @@ -98,7 +99,7 @@ void main() {

// Load kernel values from texels to array
[[unroll]] for (int i = 0; i < 4; ++i) {
const vec4 k_tex = texelFetch(t_kernel, ivec2(z + i, out_pos[2]), 0);
const vec4 k_tex = texelFetch(t_kernel, ivec2(z + i, out_pos_z), 0);
kernel_values[i * 4 + 0] = k_tex.x;
kernel_values[i * 4 + 1] = k_tex.y;
kernel_values[i * 4 + 2] = k_tex.z;
Expand Down Expand Up @@ -157,8 +158,8 @@ void main() {
}

for (int i = 0; i < TILE_SIZE_X * TILE_SIZE_Y; ++i) {
const ivec3 pos_l = ivec3(pos[i * 2], pos[i * 2 + 1], out_pos[2]);
if (all(lessThan(pos_l, out_limits.xyz))) {
const ivec3 pos_l = ivec3(pos[i * 2], pos[i * 2 + 1], out_pos_z);
if (all(lessThan(pos_l.xy, out_limits.xy))) {
imageStore(t_out, pos_l, op(vec4(sum[i * 4], sum[i * 4 + 1], sum[i * 4 + 2], sum[i * 4 + 3]), out_min, out_max));
}
}
Expand Down
Loading