Skip to content

Expose gen_oplist_lib to clients #11231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vysarat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Expose gen_oplist_lib to clients #11231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions codegen/tools/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ def define_common_targets(is_fbcode = False):
base_module = "executorch.codegen.tools",
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im fine with this but you want a yaml? Would it be better if you refactored to take a dep on an in memory represenation?

@larryliu0820 Is this representation stable for people outside ET to take a dep?

Copy link
Contributor Author

@Vysarat Vysarat Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that skipping the yaml would make things cleaner. I think that can be fixed in a follow-up PR.

Copy link
Contributor

@larryliu0820 larryliu0820 Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed let's do the hard work of exposing an API that returns the object in memory. Instead of a follow-up, can you do it first and it becomes clear on what library/target to expose publicly?

Copy link
Contributor

@JacobSzwejbka JacobSzwejbka Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also just in general it seems like all you'd need are the dtype dim order combinations for every op

],
deps = [
"//executorch/codegen:gen_lib",
Expand Down
Loading