Skip to content

Conversation

@jathu
Copy link
Contributor

@jathu jathu commented May 29, 2025

Summary

TSIA

Test plan

CI

$ .ci/scripts/test_model.sh mv3 cmake mps

@jathu jathu added ciflow/trunk ciflow/binaries release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. release notes: apple Changes to the Apple backend delegate labels May 29, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented May 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11238

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 5370c2a with merge base 809a1fd (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 29, 2025
@jathu jathu force-pushed the jathu/mps-on branch 2 times, most recently from 28ac0e9 to 3d66097 Compare May 30, 2025 00:05
@jathu jathu requested a review from mergennachin May 30, 2025 00:12
@jathu jathu force-pushed the jathu/mps-on branch 21 times, most recently from 04b12e4 to c2bb3e0 Compare May 30, 2025 17:53
@mergennachin
Copy link
Contributor

There are no reasons not to support MPS out-of-the box. I will update docs in a follow-up PR.

It's not as stable compared to coreml. Let's not do this for now.

@jathu jathu force-pushed the jathu/mps-on branch 5 times, most recently from 0717e72 to cbe805f Compare May 30, 2025 21:19
Summary:
as the title

Test Plan:
CI

Reviewers:

Subscribers:

Tasks:

Tags:
@jathu jathu changed the title Enable MPS AOT for macOS by default Add MPS runner test May 30, 2025
@jathu
Copy link
Contributor Author

jathu commented May 30, 2025

@mergennachin good point, I didn't realize MPS wasn't P0. I've repurposed the diff to include MPS runner tests, so we can still use that in the future.

@jathu jathu added release notes: none Do not include this in the release notes and removed release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. release notes: apple Changes to the Apple backend delegate labels May 30, 2025
@jathu jathu marked this pull request as ready for review May 30, 2025 21:24
@jathu jathu closed this May 30, 2025
@jathu jathu deleted the jathu/mps-on branch May 30, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants