Support approximate gelu #11246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 1 commit into pytorch:main from michaelmaitland:export-D75454999

Jun 2, 2025

Contributor

michaelmaitland commented May 30, 2025

Summary:
GELU accepts an approximate argument which is either none by default, or tanh

When the approximate kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Differential Revision: D75454999

michaelmaitland requested a review from tarun292 as a code owner

May 30, 2025 01:36

pytorch-bot bot commented May 30, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11246

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c9eb4e9 with merge base 1bc36c7 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented May 30, 2025

This pull request was exported from Phabricator. Differential Revision: D75454999

facebook-github-bot added the fb-exported label

zonglinpeng approved these changes

View reviewed changes

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

04a5137

Summary:

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from 3f8a31d to 04a5137 Compare

May 30, 2025 01:55

michaelmaitland added the topic: not user facing label

Contributor

facebook-github-bot commented May 30, 2025

This pull request was exported from Phabricator. Differential Revision: D75454999

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

53451e1

Summary:
Pull Request resolved: pytorch#11246

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from 04a5137 to 53451e1 Compare

May 30, 2025 01:58

michaelmaitland added the release notes: none label

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

61a9077

Summary:

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from 53451e1 to 61a9077 Compare

May 30, 2025 02:50

Contributor

facebook-github-bot commented May 30, 2025

This pull request was exported from Phabricator. Differential Revision: D75454999

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

08a3287

Summary:
Pull Request resolved: pytorch#11246

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from 61a9077 to 08a3287 Compare

May 30, 2025 02:53

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

df0a556

Summary:

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from 08a3287 to df0a556 Compare

May 30, 2025 19:36

Contributor

facebook-github-bot commented May 30, 2025

This pull request was exported from Phabricator. Differential Revision: D75454999

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

0bf196c

Summary:
Pull Request resolved: pytorch#11246

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from df0a556 to 0bf196c Compare

May 30, 2025 19:40

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

e39fd13

Summary:

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from 0bf196c to e39fd13 Compare

May 30, 2025 20:37

Contributor

facebook-github-bot commented May 30, 2025

This pull request was exported from Phabricator. Differential Revision: D75454999

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

Summary:
Pull Request resolved: pytorch#11246

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from e39fd13 to 4492248 Compare

May 30, 2025 20:41

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

cf1a530

Summary:

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from 4492248 to cf1a530 Compare

May 30, 2025 21:02

Contributor

facebook-github-bot commented May 30, 2025

This pull request was exported from Phabricator. Differential Revision: D75454999

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

e7405e8

Summary:
Pull Request resolved: pytorch#11246

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from cf1a530 to e7405e8 Compare

May 30, 2025 21:05

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

c6af1dd

Summary:

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from e7405e8 to c6af1dd Compare

May 30, 2025 21:21

Contributor

facebook-github-bot commented May 30, 2025

This pull request was exported from Phabricator. Differential Revision: D75454999

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

bf0504d

Summary:
Pull Request resolved: pytorch#11246

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from c6af1dd to bf0504d Compare

May 30, 2025 21:28

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

35f95c1

Summary:

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from bf0504d to 35f95c1 Compare

May 30, 2025 22:01

Contributor

facebook-github-bot commented May 30, 2025

This pull request was exported from Phabricator. Differential Revision: D75454999

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

605e1fb

Summary:
Pull Request resolved: pytorch#11246

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch 2 times, most recently from 605e1fb to ac8662a Compare

June 2, 2025 15:26

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

ac8662a

Summary:

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999

Contributor

facebook-github-bot commented Jun 2, 2025

This pull request was exported from Phabricator. Differential Revision: D75454999

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

faff995

Summary:
Pull Request resolved: pytorch#11246

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch 2 times, most recently from faff995 to 0465717 Compare

June 2, 2025 19:07

michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request


          Support approximate gelu (pytorch#11246)

Summary:

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999


          Support approximate gelu (pytorch#11246)

c9eb4e9

Summary:
Pull Request resolved: pytorch#11246

GELU accepts an `approximate` argument which is either `none` by default, or `tanh`

When the `approximate` kwarg is present, decompose the op.

We already have an existing test in test_aten_gelu_out to make sure the op is supported.

Reviewed By: zonglinpeng, hsharma35

Differential Revision: D75454999

Contributor

facebook-github-bot commented Jun 2, 2025

This pull request was exported from Phabricator. Differential Revision: D75454999

michaelmaitland force-pushed the export-D75454999 branch from 0465717 to c9eb4e9 Compare

June 2, 2025 19:10

facebook-github-bot merged commit b5567be into pytorch:main

96 of 98 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported release notes: none topic: not user facing