Skip to content

[ET-VK][ez] Updates to DynamicDispatchNode #11254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 2, 2025
Merged

[ET-VK][ez] Updates to DynamicDispatchNode #11254

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b576071
[ET-VK][ez] Updates to DynamicDispatchNode
SS-JIA May 30, 2025
68890ae
Update on "[ET-VK][ez] Updates to DynamicDispatchNode"
SS-JIA May 30, 2025
521b889
Update on "[ET-VK][ez] Updates to DynamicDispatchNode"
SS-JIA May 30, 2025
b0c9448
Update on "[ET-VK][ez] Updates to DynamicDispatchNode"
SS-JIA May 30, 2025
2029ef0
Update on "[ET-VK][ez] Updates to DynamicDispatchNode"
SS-JIA May 30, 2025
c059407
Update on "[ET-VK][ez] Updates to DynamicDispatchNode"
SS-JIA Jun 2, 2025
39e5744
Update on "[ET-VK][ez] Updates to DynamicDispatchNode"
SS-JIA Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions backends/vulkan/runtime/graph/ops/DynamicDispatchNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ DynamicDispatchNode::DynamicDispatchNode(
graph,
pick_shader_fn(&graph, args, resize_args),
pick_global_wg_fn(&graph, args, resize_args),
pick_local_wg_fn(&graph, args, resize_args),
pick_local_wg_fn(
&graph,
pick_global_wg_fn(&graph, args, resize_args),
args,
resize_args),
args,
params,
push_constants,
Expand All @@ -41,8 +45,8 @@ DynamicDispatchNode::DynamicDispatchNode(
void DynamicDispatchNode::encode(ComputeGraph* graph) {
shader_ = pick_shader_fn_(graph, args_, resize_args_);
global_workgroup_size_ = pick_global_wg_fn_(graph, args_, resize_args_);
local_workgroup_size_ =
utils::WorkgroupSize(pick_local_wg_fn_(graph, args_, resize_args_));
local_workgroup_size_ = utils::WorkgroupSize(
pick_local_wg_fn_(graph, global_workgroup_size_, args_, resize_args_));
DispatchNode::encode(graph);
}

Expand Down
1 change: 1 addition & 0 deletions backends/vulkan/runtime/graph/ops/DynamicDispatchNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class DynamicDispatchNode final : public DispatchNode {
const std::vector<ValueRef>&)>;
using PickLocalFn = const std::function<utils::uvec3(
ComputeGraph*,
const utils::uvec3& global_workgroup_size,
const std::vector<ArgGroup>&,
const std::vector<ValueRef>&)>;

Expand Down
1 change: 1 addition & 0 deletions backends/vulkan/test/vulkan_compute_api_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3323,6 +3323,7 @@ utils::uvec3 pick_dynamic_dispatch_global_wg_size(

utils::uvec3 pick_dynamic_dispatch_local_wg_size(
ComputeGraph* graph,
const utils::uvec3& global_workgroup_size,
const std::vector<ArgGroup>& args,
const std::vector<ValueRef>& additional_args) {
return {64, 1, 1};
Expand Down
Loading