Skip to content

Removed minimum target macOS 11.0 branching #11266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged

Removed minimum target macOS 11.0 branching #11266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9987459
Removed minimum target macOS 11.0 branching
NeelakshSharma May 30, 2025
50a6953
Merge branch 'main' into bugfix/remove_branching_macOS11
NeelakshSharma May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backends/apple/coreml/runtime/delegate/ETCoreMLDefaultModelExecutor.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ - (instancetype)initWithModel:(ETCoreMLModel *)model {
eventLogger:(const executorchcoreml::ModelEventLogger* _Nullable __unused)eventLogger
error:(NSError * __autoreleasing *)error {
if (self.ignoreOutputBackings) {
if (@available(macOS 11.0, iOS 16.0, tvOS 16.0, watchOS 9.0, *)) {
if (@available(iOS 16.0, tvOS 16.0, watchOS 9.0, *)) {
predictionOptions.outputBackings = @{};
}
}
Expand Down
4 changes: 2 additions & 2 deletions backends/apple/coreml/runtime/delegate/ETCoreMLModelManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ BOOL is_backed_by_same_buffer(MLMultiArray *array1, MLMultiArray *array2) {
NSOrderedSet<NSString *> *output_names,
NSError * __autoreleasing *error) {
MLPredictionOptions *options = [MLPredictionOptions new];
if (@available(macOS 11.0, iOS 16.0, tvOS 16.0, watchOS 9.0, *)) {
if (@available(iOS 16.0, tvOS 16.0, watchOS 9.0, *)) {
NSMutableDictionary<NSString *, id> *output_backings = [NSMutableDictionary dictionary];
NSEnumerator<NSString *> *enumerator = [output_names objectEnumerator];
for (MLMultiArray *output in outputs) {
Expand Down Expand Up @@ -687,7 +687,7 @@ - (void)addPrewarmedAsset:(ETCoreMLAsset *)asset {
eventLogger:eventLogger
error:&localError];
// Try without output backings.
if (@available(macOS 11.0, iOS 16.0, tvOS 16.0, watchOS 9.0, *)) {
if (@available(iOS 16.0, tvOS 16.0, watchOS 9.0, *)) {
if (!modelOutputs && predictionOptions.outputBackings.count > 0) {
executor.ignoreOutputBackings = YES;
localError = nil;
Expand Down
Loading