Improve torch.ops typing #11276
Closed
Improve torch.ops typing #11276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11276
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 361ffdf with merge base 63b047b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75497142 |
aorenste
added a commit
to aorenste/pytorch
that referenced
this pull request
Jun 2, 2025
Summary: X-link: pytorch/executorch#11276 Cloned pytorch#153558 from benjaminglass1 and fixed internal typing errors. Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that `__getattr__` can return a single type in all other cases. Decisions made along the way: 1. `torch.ops.higher_order` is now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the `_Ops` class. 2. `__getattr__` is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables. The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues. Test Plan: CI Differential Revision: D75497142
oulgen
approved these changes
Jun 3, 2025
aorenste
force-pushed
the
export-D75497142
branch
from
0d62b68 to
891904a
Compare
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Jun 3, 2025
Summary: X-link: pytorch/pytorch#154555 Cloned pytorch/pytorch#153558 from benjaminglass1 and fixed internal typing errors. Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that `__getattr__` can return a single type in all other cases. Decisions made along the way: 1. `torch.ops.higher_order` is now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the `_Ops` class. 2. `__getattr__` is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables. The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues. Reviewed By: bobrenjc93 Differential Revision: D75497142
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75497142 |
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Jun 3, 2025
Summary: Pull Request resolved: pytorch#11276 X-link: pytorch/pytorch#154555 Cloned pytorch/pytorch#153558 from benjaminglass1 and fixed internal typing errors. Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that `__getattr__` can return a single type in all other cases. Decisions made along the way: 1. `torch.ops.higher_order` is now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the `_Ops` class. 2. `__getattr__` is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables. The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues. Reviewed By: bobrenjc93 Differential Revision: D75497142
aorenste
force-pushed
the
export-D75497142
branch
from
891904a to
7bf216c
Compare
mergennachin
approved these changes
Jun 4, 2025
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75497142 |
aorenste
force-pushed
the
export-D75497142
branch
from
7bf216c to
4d873f4
Compare
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: pytorch#11276 X-link: pytorch/pytorch#154555 Cloned pytorch/pytorch#153558 from benjaminglass1 and fixed internal typing errors. Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that `__getattr__` can return a single type in all other cases. Decisions made along the way: 1. `torch.ops.higher_order` is now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the `_Ops` class. 2. `__getattr__` is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables. The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues. Reviewed By: bobrenjc93, mergennachin Differential Revision: D75497142
pytorch-bot bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jun 12, 2025
Summary: X-link: pytorch/executorch#11276 Pull Request resolved: #154555 Cloned #153558 from benjaminglass1 and fixed internal typing errors. Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that `__getattr__` can return a single type in all other cases. Decisions made along the way: 1. `torch.ops.higher_order` is now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the `_Ops` class. 2. `__getattr__` is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables. The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues. Test Plan: CI Reviewed By: bobrenjc93, mergennachin Differential Revision: D75497142
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75497142 |
aorenste
force-pushed
the
export-D75497142
branch
from
4d873f4 to
b44f864
Compare
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Jun 13, 2025
Summary: Pull Request resolved: pytorch#11276 X-link: pytorch/pytorch#154555 Cloned pytorch/pytorch#153558 from benjaminglass1 and fixed internal typing errors. Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that `__getattr__` can return a single type in all other cases. Decisions made along the way: 1. `torch.ops.higher_order` is now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the `_Ops` class. 2. `__getattr__` is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables. The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues. Reviewed By: bobrenjc93, mergennachin Differential Revision: D75497142
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75497142 |
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Jun 13, 2025
Summary: Pull Request resolved: pytorch#11276 X-link: pytorch/pytorch#154555 Cloned pytorch/pytorch#153558 from benjaminglass1 and fixed internal typing errors. Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that `__getattr__` can return a single type in all other cases. Decisions made along the way: 1. `torch.ops.higher_order` is now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the `_Ops` class. 2. `__getattr__` is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables. The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues. Reviewed By: bobrenjc93, mergennachin Differential Revision: D75497142
aorenste
force-pushed
the
export-D75497142
branch
from
b44f864 to
900074f
Compare
aorenste
added a commit
to aorenste/pytorch
that referenced
this pull request
Jun 13, 2025
Summary: X-link: pytorch/executorch#11276 Pull Request resolved: pytorch#154555 Cloned pytorch#153558 from benjaminglass1 and fixed internal typing errors. Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that `__getattr__` can return a single type in all other cases. Decisions made along the way: 1. `torch.ops.higher_order` is now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the `_Ops` class. 2. `__getattr__` is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables. The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues. Test Plan: CI Reviewed By: bobrenjc93, mergennachin Differential Revision: D75497142
aorenste
force-pushed
the
export-D75497142
branch
from
900074f to
648a803
Compare
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Jun 20, 2025
Summary: X-link: pytorch/pytorch#154555 Cloned pytorch/pytorch#153558 from benjaminglass1 and fixed internal typing errors. Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that `__getattr__` can return a single type in all other cases. Decisions made along the way: 1. `torch.ops.higher_order` is now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the `_Ops` class. 2. `__getattr__` is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables. The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues. Reviewed By: bobrenjc93, mergennachin Differential Revision: D75497142
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75497142 |
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Jun 20, 2025
Summary: Pull Request resolved: pytorch#11276 X-link: pytorch/pytorch#154555 Cloned pytorch/pytorch#153558 from benjaminglass1 and fixed internal typing errors. Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that `__getattr__` can return a single type in all other cases. Decisions made along the way: 1. `torch.ops.higher_order` is now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the `_Ops` class. 2. `__getattr__` is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables. The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues. Reviewed By: bobrenjc93, mergennachin Differential Revision: D75497142
aorenste
force-pushed
the
export-D75497142
branch
from
d1d1f14 to
f6975b4
Compare
aorenste
added a commit
to aorenste/pytorch
that referenced
this pull request
Jun 21, 2025
Summary: X-link: pytorch/executorch#11276 Cloned pytorch#153558 from benjaminglass1 and fixed internal typing errors. Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that `__getattr__` can return a single type in all other cases. Decisions made along the way: 1. `torch.ops.higher_order` is now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the `_Ops` class. 2. `__getattr__` is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables. The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues. Test Plan: CI Reviewed By: bobrenjc93, mergennachin Differential Revision: D75497142
aorenste
force-pushed
the
export-D75497142
branch
from
f6975b4 to
361ffdf
Compare
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Jun 21, 2025
Summary: X-link: pytorch/pytorch#154555 Cloned pytorch/pytorch#153558 from benjaminglass1 and fixed internal typing errors. Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that `__getattr__` can return a single type in all other cases. Decisions made along the way: 1. `torch.ops.higher_order` is now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the `_Ops` class. 2. `__getattr__` is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables. The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues. Reviewed By: bobrenjc93, mergennachin Differential Revision: D75497142
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75497142 |
aorenste
added a commit
to aorenste/pytorch
that referenced
this pull request
Jun 21, 2025
Summary: X-link: pytorch/executorch#11276 Cloned pytorch#153558 from benjaminglass1 and fixed internal typing errors. Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that `__getattr__` can return a single type in all other cases. Decisions made along the way: 1. `torch.ops.higher_order` is now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the `_Ops` class. 2. `__getattr__` is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables. The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues. Test Plan: CI Reviewed By: bobrenjc93, mergennachin Differential Revision: D75497142
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75497142 |
aorenste
force-pushed
the
export-D75497142
branch
from
361ffdf to
a12a005
Compare
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/pytorch#154555
Cloned pytorch/pytorch#153558 from benjaminglass1 and fixed internal typing errors.
Fixes longstanding issue where direct references to aten operations are seen as untyped by type checkers. This is accomplished by setting attributes on several classes more consistently, so that
__getattr__can return a single type in all other cases.Decisions made along the way:
torch.ops.higher_orderis now implemented by a single-purpose class. This was effectively true before, but the class implementing it attempted to be generalized unnecessarily. Fixing this simplified typing for the_Opsclass.__getattr__is only called when all other lookup methods have failed, so several constant special-cases in the function could be implemented as class variables.The remainder of this PR is fixing up all the bugs exposed by the updated typing, as well as all the nitpicky typing issues.
Differential Revision: D75497142
Co-authored-by: Benjamin Glass [email protected]