Skip to content

Conversation

@Juntian777
Copy link
Contributor

Summary: Make the intermediate output capturer more extensible by adding a NodeFilter class. Add one rule to the intermediate output capturer to skip the getitem node for now.

Differential Revision: D75699297

@Juntian777 Juntian777 requested a review from Gasoonjia as a code owner June 2, 2025 17:35
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11289

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5c3b4f3 with merge base 8e2737c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 2, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75699297

Copy link
Contributor

@Gasoonjia Gasoonjia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Juntian777
Copy link
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Jun 2, 2025
Juntian777 pushed a commit to Juntian777/executorch that referenced this pull request Jun 2, 2025
Summary:

Make the intermediate output capturer more extensible by adding a NodeFilter class. Add one rule to the intermediate output capturer to skip the getitem node for now.

Reviewed By: Gasoonjia

Differential Revision: D75699297
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75699297

Juntian777 pushed a commit to Juntian777/executorch that referenced this pull request Jun 2, 2025
Summary:
Pull Request resolved: pytorch#11289

Make the intermediate output capturer more extensible by adding a NodeFilter class. Add one rule to the intermediate output capturer to skip the getitem node for now.

Reviewed By: Gasoonjia

Differential Revision: D75699297
Juntian777 pushed a commit to Juntian777/executorch that referenced this pull request Jun 2, 2025
Summary:

Make the intermediate output capturer more extensible by adding a NodeFilter class. Add one rule to the intermediate output capturer to skip the getitem node for now.

Reviewed By: Gasoonjia

Differential Revision: D75699297
Summary:
Pull Request resolved: pytorch#11289

Make the intermediate output capturer more extensible by adding a NodeFilter class. Add one rule to the intermediate output capturer to skip the getitem node for now.

Reviewed By: Gasoonjia

Differential Revision: D75699297
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75699297

@facebook-github-bot facebook-github-bot merged commit 2642e47 into pytorch:main Jun 3, 2025
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants