Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/scripts/label_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@

LABEL_ERR_MSG_TITLE = "This PR needs a `release notes:` label"
LABEL_ERR_MSG = f"""# {LABEL_ERR_MSG_TITLE}
If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with `release notes:`.

If not, please add the `release notes: none` label.
If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with `release notes:`. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
`@pytorchbot label "release notes: none"`
Expand Down
10 changes: 1 addition & 9 deletions .github/scripts/trymerge.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,7 @@
patterns_to_regex,
retries_decorator,
)
from label_utils import (
gh_add_labels,
gh_remove_label,
has_required_labels,
LABEL_ERR_MSG,
)
from label_utils import gh_add_labels, gh_remove_label
from trymerge_explainer import get_revert_message, TryMergeExplainer

# labels
Expand Down Expand Up @@ -2116,9 +2111,6 @@ def merge(
# Check for approvals
find_matching_merge_rule(pr, repo, skip_mandatory_checks=True)

if not has_required_labels(pr):
raise RuntimeError(LABEL_ERR_MSG.lstrip(" #"))

if ignore_current:
checks = pr.get_checkrun_conclusions()
_, failing, _ = categorize_checks(
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ jobs:
PR_NUM: ${{ github.event.number || github.event.inputs.pr_number }}
run: |
set -ex
python3 .github/scripts/check_labels.py --exit-non-zero "${PR_NUM}"
python3 .github/scripts/check_labels.py "${PR_NUM}"
Loading