-
Notifications
You must be signed in to change notification settings - Fork 712
Mitigate coremltool issue with python 3.13 #11317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add blobwriter error to common issues
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11317
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 1 PendingAs of commit c1a4902 with merge base 5ef38d3 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
docs/source/backends-coreml.md
Outdated
| 2. coremltools/converters/mil/backend/mil/load.py", line 499, in export | ||
| raise RuntimeError("BlobWriter not loaded") | ||
|
|
||
| If you're using Python 3.13, try reducing your python version to Python 3.12. coremltools does not support Python 3.13. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we link to apple/coremltools#2487 so people can easily tell when this goes stale?
|
What if we just hard enforce 3.12 as the upper bound version? Lines 51 to 52 in 5ef38d3
|
I think this is a good idea |
pyproject.toml
Outdated
| # Python dependencies required for use. | ||
| requires-python = ">=3.10" | ||
| # coremltools has issue with python 3.13, see https://github.com/apple/coremltools/issues/2487 | ||
| requires-python = ">=3.10,<=3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should change this to sub 13
| requires-python = ">=3.10,<=3.12" | |
| requires-python = ">=3.10,<3.13" |
|
Interestingly enough, I can install coremltools==8.3.0 and 9.0b1, but not executorch when I revert requires-python, so binary wheels from cibuildwheel would be greatly appreciated as always 😄 .venv/bin/python' '-c' 'import importlib.util; print(importlib.util.find_spec('torch').submodule_search_locations[0])'
Error while adding torch to CMAKE_PREFIX_PATH. Exit code: 1
Output:
CMake Error at tools/cmake/Utils.cmake:135 (message):
Error:
Traceback (most recent call last):
File "<string>", line 1, in <module>
import importlib.util; print(importlib.util.find_spec('torch').submodule_search_locations[0])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute
'submodule_search_locations'
Call Stack (most recent call first):
tools/cmake/Utils.cmake:109 (get_torch_base_path)
CMakeLists.txt:470 (find_package_torch_headers)
-- Configuring incomplete, errors occurred!By the way, if I move up EXECUTORCH_ROOT_PATH in backends/apple/coreml/scripts/install_requirements.sh this seems to work to remove manual syncing: COREMLTOOLS_VERSION="$(grep coremltools== $EXECUTORCH_ROOT_PATH/pyproject.toml | grep -Eo '[0-9]+\.[0-9]+[^ ;"]*')" |
No description provided.