Skip to content

Conversation

@metascroy
Copy link
Contributor

No description provided.

Add blobwriter error to common issues
@metascroy metascroy requested review from jathu and swolchok June 3, 2025 17:55
@metascroy metascroy requested a review from mergennachin as a code owner June 3, 2025 17:55
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11317

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Pending

As of commit c1a4902 with merge base 5ef38d3 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2025
@github-actions
Copy link

github-actions bot commented Jun 3, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

2. coremltools/converters/mil/backend/mil/load.py", line 499, in export
raise RuntimeError("BlobWriter not loaded")

If you're using Python 3.13, try reducing your python version to Python 3.12. coremltools does not support Python 3.13.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we link to apple/coremltools#2487 so people can easily tell when this goes stale?

@jathu
Copy link
Contributor

jathu commented Jun 3, 2025

What if we just hard enforce 3.12 as the upper bound version?

# Python dependencies required for use.
requires-python = ">=3.10"

@metascroy
Copy link
Contributor Author

What if we just hard enforce 3.12 as the upper bound version?

# Python dependencies required for use.
requires-python = ">=3.10"

I think this is a good idea

@metascroy
Copy link
Contributor Author

What if we just hard enforce 3.12 as the upper bound version?

# Python dependencies required for use.
requires-python = ">=3.10"

I think this is a good idea

@jathu added 3.13 upper bound to pyproject.toml. Can you have a look?

@metascroy metascroy changed the title Update backends-coreml.md Mitigate coremltool issue with python 3.13 Jun 3, 2025
pyproject.toml Outdated
# Python dependencies required for use.
requires-python = ">=3.10"
# coremltools has issue with python 3.13, see https://github.com/apple/coremltools/issues/2487
requires-python = ">=3.10,<=3.12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should change this to sub 13

Suggested change
requires-python = ">=3.10,<=3.12"
requires-python = ">=3.10,<3.13"

@metascroy metascroy merged commit 3fe276e into main Jun 3, 2025
195 of 197 checks passed
@metascroy metascroy deleted the metascroy-patch-2 branch June 3, 2025 21:57
@reneleonhardt
Copy link

reneleonhardt commented Oct 7, 2025

Interestingly enough, I can install coremltools==8.3.0 and 9.0b1, but not executorch when I revert requires-python, so binary wheels from cibuildwheel would be greatly appreciated as always 😄

.venv/bin/python' '-c' 'import importlib.util; print(importlib.util.find_spec('torch').submodule_search_locations[0])'
      Error while adding torch to CMAKE_PREFIX_PATH. Exit code: 1
      Output:
      
      CMake Error at tools/cmake/Utils.cmake:135 (message):
        Error:
      
        Traceback (most recent call last):
      
          File "<string>", line 1, in <module>
            import importlib.util; print(importlib.util.find_spec('torch').submodule_search_locations[0])
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      
        AttributeError: 'NoneType' object has no attribute
        'submodule_search_locations'
      
      Call Stack (most recent call first):
        tools/cmake/Utils.cmake:109 (get_torch_base_path)
        CMakeLists.txt:470 (find_package_torch_headers)
      
      
      -- Configuring incomplete, errors occurred!

By the way, if I move up EXECUTORCH_ROOT_PATH in backends/apple/coreml/scripts/install_requirements.sh this seems to work to remove manual syncing:

COREMLTOOLS_VERSION="$(grep coremltools== $EXECUTORCH_ROOT_PATH/pyproject.toml | grep -Eo '[0-9]+\.[0-9]+[^ ;"]*')"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants