[ET-VK] Use push constants for image and buffer to nchw prepack nodes. #11371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request resolved: #11305 This diff modifies the Vulkan backend to use push constants for image and buffer to NCHW prepack nodes, allowing for a more efficient way of passing data to shaders. ghstack-source-id: 288178299 Differential Revision: [D75702273](https://our.internmc.facebook.com/intern/diff/D75702273/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11371
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 PendingAs of commit b40cef9 with merge base 911fb0b ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
trivedivivek
added
the
release notes: vulkan
trivedivivek
approved these changes
Jun 4, 2025
) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11306 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/110/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/110/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/109/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/110/orig @diff-train-skip-merge Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11305 by @trivedivivek
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/109/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/109/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/109/orig
@diff-train-skip-merge