Skip to content

Qualcomm AI Engine Direct - Deprecate convert_bmm_to_matmul pass #11392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cccclai merged 3 commits into from
Jun 17, 2025
Merged

Qualcomm AI Engine Direct - Deprecate convert_bmm_to_matmul pass #11392

cccclai merged 3 commits into from
Jun 17, 2025

Conversation

@DannyYuyang-quic
Copy link
Contributor

@DannyYuyang-quic DannyYuyang-quic commented Jun 5, 2025

Summary

  • delete convert_bmm_to_matmul pass
  • add torch.ops.aten.matmul.default in skip_decomp_table

Test plan

General CI

@DannyYuyang-quic
Qualcomm AI Engine Direct - Deprecate convert_bmm_to_matmul pass
858fd02 
Summary:
- delete convert_bmm_to_matmul pass
- add torch.ops.aten.matmul.default in skip_decomp_table
@DannyYuyang-quic DannyYuyang-quic requested a review from cccclai as a code owner June 5, 2025 05:39
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11392

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c43e821 with merge base aed9c7e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2025
@DannyYuyang-quic
Copy link
Contributor Author

DannyYuyang-quic commented Jun 5, 2025

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Jun 5, 2025
@DannyYuyang-quic
Copy link
Contributor Author

DannyYuyang-quic commented Jun 5, 2025 •
edited
Loading

Hi @cccclai,
By including torch.ops.aten.matmul.default in skip_decompositions, we can drop the convert_bmm_to_matmul pass, it’s no longer needed.
Please have a look.
Thanks!

cccclai
cccclai approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 5, 2025

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Contributor

cccclai commented Jun 6, 2025

Hey can you help rebasing?

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 10, 2025

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 13, 2025

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai cccclai merged commit 7503bb3 into pytorch:main Jun 17, 2025
97 checks passed
@shewu-quic shewu-quic mentioned this pull request Jun 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccclai cccclai cccclai approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DannyYuyang-quic @facebook-github-bot @cccclai