Skip to content

Conversation

Sebastian-Larsson
Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson commented Jun 5, 2025

  • annotate_channels_last_dim_order_pass: raise on dim_order length != 4 and != 5
  • remove_clone_pass: ValueError if args count != 1
  • fold_qdq_with_annotated_qparams_pass: RuntimeError if dq_op mismatch or unexpected meta key presence
  • convert_split_to_slice: ValueError if split sizes don't match dim
  • insert_table_ops: ValueError if input/output quant params count != 1

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- annotate_channels_last_dim_order_pass: raise on dim_order length != 4
  and != 5
- remove_clone_pass: ValueError if args count != 1
- fold_qdq_with_annotated_qparams_pass: RuntimeError if dq_op mismatch
  or unexpected meta key presence
- convert_split_to_slice: ValueError if split sizes don't match dim
- insert_table_ops: ValueError if input/output quant params count != 1

Change-Id: Ie3d2fa0b7a352fa6f4ba5544b6481d87b8b17b5e
Signed-off-by: Sebastian Larsson <[email protected]>
@Sebastian-Larsson Sebastian-Larsson added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Jun 5, 2025
Copy link

pytorch-bot bot commented Jun 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11394

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit a211f16 with merge base 60929cf (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2025
@zingo
Copy link
Collaborator

zingo commented Jun 5, 2025

Cortex-M size test error is unrelated as this only changes python file and nothing on the target.
Also this test fails on main since #10675

@zingo zingo merged commit c120b35 into pytorch:main Jun 5, 2025
278 of 280 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants