Skip to content

Move gflags to third-party #11448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jathu merged 3 commits into from
Jun 9, 2025
Merged

Move gflags to third-party #11448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f58949
✨ Integrate gflags library into build configuration
jathu Jun 6, 2025
a0724a8
Merge branch 'main' into jathu/move-gflags
jathu Jun 9, 2025
7fd7ba7
Merge branch 'main' into jathu/move-gflags
jathu Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,14 +430,6 @@ endif()

add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/configurations)

#
# gflags: Commandline flag host library.
#

if(EXECUTORCH_BUILD_GFLAGS)
add_subdirectory(third-party/gflags)
endif()

# Install `executorch` library as well as `executorch-config.cmake` under
# ${CMAKE_INSTALL_PREFIX}/
install(
Expand Down
3 changes: 1 addition & 2 deletions backends/apple/coreml/scripts/build_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ cmake "$EXECUTORCH_ROOT_PATH" -B"$CMAKE_EXECUTORCH_BUILD_DIR_PATH" \
-DPLATFORM=MAC_UNIVERSAL \
-DDEPLOYMENT_TARGET=13.0 \
-DEXECUTORCH_BUILD_EXECUTOR_RUNNER=OFF \
-DEXECUTORCH_BUILD_XNNPACK=OFF \
-DEXECUTORCH_BUILD_GFLAGS=OFF
-DEXECUTORCH_BUILD_XNNPACK=OFF

cmake --build "$CMAKE_EXECUTORCH_BUILD_DIR_PATH" -j9 -t executorch

Expand Down
1 change: 0 additions & 1 deletion backends/cadence/build_cadence_fusionG3.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ if $STEPWISE_BUILD; then
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=OFF \
-DPYTHON_EXECUTABLE=python3 \
-DEXECUTORCH_FUSION_G3_OPT=ON \
-DEXECUTORCH_BUILD_GFLAGS=ON \
-DHAVE_FNMATCH_H=OFF \
-Bcmake-out/backends/cadence \
backends/cadence
Expand Down
1 change: 0 additions & 1 deletion backends/cadence/build_cadence_hifi4.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ if $STEPWISE_BUILD; then
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=OFF \
-DPYTHON_EXECUTABLE=python3 \
-DEXECUTORCH_NNLIB_OPT=ON \
-DEXECUTORCH_BUILD_GFLAGS=ON \
-DHAVE_FNMATCH_H=OFF \
-Bcmake-out/backends/cadence \
backends/cadence
Expand Down
1 change: 1 addition & 0 deletions third-party/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# LICENSE file in the root directory of this source tree.

add_subdirectory(json)
add_subdirectory(gflags)

if(EXECUTORCH_BUILD_PYBIND)
add_subdirectory(pybind11)
Expand Down
5 changes: 0 additions & 5 deletions tools/cmake/preset/default.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,11 +209,6 @@ define_overridable_option(
"Build the Cortex-M backend"
BOOL OFF
)
define_overridable_option(
EXECUTORCH_BUILD_GFLAGS
"Build the gflags library."
BOOL ON
)
define_overridable_option(
EXECUTORCH_COREML_BUILD_EXECUTOR_RUNNER
"Build CoreML executor runner."
Expand Down
Loading