Skip to content

Conversation

@jathu
Copy link
Contributor

@jathu jathu commented Jun 6, 2025

Summary

We currently have some flags that cannot be turned on with other flags. We currently work around this be implicitly flipping the other flags. Let's make this violation explicit now and expect the users to exclude the conflicting flag.

Example:

executorch/CMakeLists.txt

Lines 550 to 563 in b632906

if(EXECUTORCH_BUILD_DEVTOOLS)
if(NOT EXECUTORCH_BUILD_ARM_BAREMETAL)
set(EXECUTORCH_BUILD_EXTENSION_DATA_LOADER
ON
CACHE BOOL "EXECUTORCH_BUILD_EXTENSION_DATA_LOADER" FORCE
)
else()
set(EXECUTORCH_BUILD_EXTENSION_DATA_LOADER
OFF
CACHE BOOL "EXECUTORCH_BUILD_EXTENSION_DATA_LOADER" FORCE
)
endif()
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/devtools)
endif()

Test plan

$ python -m unittest tools.cmake.common.preset_test.TestPreset

cc @larryliu0820

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11460

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 88 Pending, 1 Unrelated Failure

As of commit cbafa43 with merge base b632906 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
@jathu jathu added release notes: none Do not include this in the release notes module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch labels Jun 6, 2025
@jathu jathu marked this pull request as ready for review June 6, 2025 22:40
@jathu jathu merged commit 2bb567f into main Jun 6, 2025
94 of 98 checks passed
@jathu jathu deleted the jathu/cmake-conflict branch June 6, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants