Skip to content

Conversation

@KamilMatejuk
Copy link

Summary

Executorch installation with OpenVINO backend by default accepts only build_type (either --cpp_runtime or --enable_python. However, internally it runs install_executorch.sh which COULD accept arguments:

  • --use-pt-pinned-commit
  • --editable

but there is no way to set them. This PR aims to pass those arguments from running openvino_build.sh into install_executorch.sh.

Test plan

Tested commands:

bash backends/openvino/scripts/openvino_build.sh --enable_python
bash backends/openvino/scripts/openvino_build.sh --enable_python --use-pt-pinned-commit

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11469

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6530a7f with merge base f24351a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @KamilMatejuk!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@KamilMatejuk
Copy link
Author

@pytorchbot label "release notes: backends"

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 9, 2025

Didn't find following labels among repository labels: release notes: backends

@KamilMatejuk
Copy link
Author

@pytorchbot label "Release notes: backends"

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 9, 2025

Didn't find following labels among repository labels: Release notes: backends

@KamilMatejuk
Copy link
Author

@pytorchbot label "Release notes: backend"

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 9, 2025

Didn't find following labels among repository labels: Release notes: backend

@KamilMatejuk
Copy link
Author

@pytorchbot label "release notes: openvino"

@pytorch-bot pytorch-bot bot added the release notes: openvino OpenVino backend related issues, features, bugs etc. label Jun 9, 2025
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2025
@JacobSzwejbka
Copy link
Contributor

some merge conflicts. Im asking around for the openvino poc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: openvino OpenVino backend related issues, features, bugs etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants