Arm backend: Add validate_valid_dtype #11472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebastian-Larsson
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11472
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Unrelated FailuresAs of commit 029aa08 with merge base 045b3a5 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Collaborator
|
@Sebastian-Larsson this seem to need a rebase :( |
Add a new validate_valid_dtype helper in operator_validation_utils to centralize and standardize dtype validation logic across all ARM backend operators. Manual, duplicated dtype checks in individual operator visitors have been replaced with calls to validate_valid_dtype. Signed-off-by: Sebastian Larsson <[email protected]> Change-Id: I4ba6d0bd11474fa41e75637563e603b5cc080f63
Sebastian-Larsson
force-pushed
the
validate_valid_dtype
branch
from
da8dc2c to
029aa08
Compare
zingo
approved these changes
Jun 13, 2025
Collaborator
|
Fails unrelated and fails a main also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new validate_valid_dtype helper in operator_validation_utils to centralize and standardize dtype validation logic across all ARM backend operators. Manual, duplicated dtype checks in individual operator visitors have been replaced with calls to validate_valid_dtype.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218