Skip to content

Conversation

@jathu
Copy link
Contributor

@jathu jathu commented Jun 9, 2025

Summary

Similar to #11457, but now we also want to warn against unsupported/conflicting flags. For example, when using EXECUTORCH_BUILD_ARM_BAREMETAL, we cannot enable certain flags.

Test plan

CI

$ cmake -DEXECUTORCH_BUILD_ARM_BAREMETAL=ON --preset macos

CMake Error at tools/cmake/common/preset.cmake:142 (message):
  Both 'EXECUTORCH_BUILD_ARM_BAREMETAL' and
  'EXECUTORCH_BUILD_EXTENSION_DATA_LOADER' can't be ON
Call Stack (most recent call first):
  tools/cmake/preset/default.cmake:352 (check_conflicting_options_on)
  CMakeLists.txt:87 (include)

cc @larryliu0820 @digantdesai @freddan80 @per @zingo @oscarandersson8218

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries release notes: none Do not include this in the release notes labels Jun 9, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11493

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 8ce3d08 with merge base ce48e0d (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2025
@jathu jathu requested a review from zingo June 9, 2025 17:47
@jathu jathu added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jun 9, 2025
@jathu jathu force-pushed the jathu/cmake-conflict branch 2 times, most recently from cae4da2 to 2a2cf98 Compare June 9, 2025 19:12
@jathu jathu marked this pull request as ready for review June 9, 2025 19:12
@jathu jathu force-pushed the jathu/cmake-conflict branch from 2a2cf98 to 8ce3d08 Compare June 9, 2025 19:12
@zingo
Copy link
Collaborator

zingo commented Jun 10, 2025

Thanks, if this combination don't work we should try to fix it :)

@jathu jathu merged commit c12ecbe into main Jun 10, 2025
293 of 295 checks passed
@jathu jathu deleted the jathu/cmake-conflict branch June 10, 2025 14:56
@swolchok
Copy link
Contributor

swolchok commented Jul 21, 2025

Both 'EXECUTORCH_BUILD_ARM_BAREMETAL' and
'EXECUTORCH_BUILD_EXTENSION_DATA_LOADER' can't be ON

The ARM size test builds with EXECUTORCH_BUILD_ARM_BAREMETAL, and size_test.cpp requires FileDataLoader (and, currently, incorrectly doesn't enable it). Is it OK to remove this constraint?

@jathu
Copy link
Contributor Author

jathu commented Jul 21, 2025

@swolchok I'm not sure, you can try it. I tried retaining the existing behavior where EXECUTORCH_BUILD_EXTENSION_DATA_LOADER was turned off if baremetal was on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants