Replace debug handle with from_node to trace operator transformation
#11532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11532
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit fe54b74 with merge base 67b6009 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76168997 |
Contributor
Author
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76168997 |
Gasoonjia
force-pushed
the
export-D76168997
branch
from
c685371 to
8a43fe7
Compare
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Jun 12, 2025
pytorch#11532) Summary: Pull Request resolved: pytorch#11532 X-link: pytorch/ao#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Gasoonjia
added a commit
to Gasoonjia/ao
that referenced
this pull request
Jun 12, 2025
pytorch#2339) Summary: X-link: pytorch/executorch#11532 Pull Request resolved: pytorch#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Gasoonjia
added a commit
to Gasoonjia/ao
that referenced
this pull request
Jun 12, 2025
pytorch#2339) Summary: X-link: pytorch/executorch#11532 Pull Request resolved: pytorch#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Gasoonjia
added a commit
to Gasoonjia/ao
that referenced
this pull request
Jun 12, 2025
pytorch#2339) Summary: X-link: pytorch/executorch#11532 Pull Request resolved: pytorch#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76168997 |
Gasoonjia
force-pushed
the
export-D76168997
branch
from
8a43fe7 to
89503bf
Compare
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Jun 12, 2025
pytorch#11532) Summary: Pull Request resolved: pytorch#11532 X-link: pytorch/ao#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76168997 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Jun 12, 2025
pytorch#11532) Summary: Pull Request resolved: pytorch#11532 X-link: pytorch/ao#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Gasoonjia
force-pushed
the
export-D76168997
branch
from
89503bf to
d3093f9
Compare
pytorch#11532) Summary: Pull Request resolved: pytorch#11532 X-link: pytorch/ao#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76168997 |
Gasoonjia
force-pushed
the
export-D76168997
branch
from
d3093f9 to
fe54b74
Compare
Gasoonjia
added a commit
to Gasoonjia/ao
that referenced
this pull request
Jun 18, 2025
pytorch#2339) Summary: X-link: pytorch/executorch#11532 Pull Request resolved: pytorch#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Gasoonjia
added a commit
to pytorch/ao
that referenced
this pull request
Jun 18, 2025
#2339) Replace debug handle with `from_node` to trace operator transformation (#2339) Summary: X-link: pytorch/executorch#11532 Pull Request resolved: #2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
xiaowangintel
pushed a commit
to xiaowangintel/ao
that referenced
this pull request
Jun 24, 2025
pytorch#2339) Replace debug handle with `from_node` to trace operator transformation (pytorch#2339) Summary: X-link: pytorch/executorch#11532 Pull Request resolved: pytorch#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
digantdesai
reviewed
Jun 25, 2025
| nonlocal prev_decomp_op_to_debug_handle_map | ||
| if FROM_NODE_KEY in node.meta: | ||
| prev_decomp_op = str(node.meta.get("nn_module_stack")) | ||
| debug_handle = _generate_debug_handle_from_node(node) |
Contributor
There was a problem hiding this comment.
is from_node a new thing?
Contributor
Author
There was a problem hiding this comment.
it is introduced after torch 2.6 and we will use that to trace the node transformation from torch.export to torchao to edge.
digantdesai
approved these changes
Jun 25, 2025
Contributor
digantdesai
left a comment
digantdesai
left a comment
There was a problem hiding this comment.
This is mainly updating the test, so ok with merging this.
liangel-02
pushed a commit
to pytorch/ao
that referenced
this pull request
Aug 25, 2025
#2339) Replace debug handle with `from_node` to trace operator transformation (#2339) Summary: X-link: pytorch/executorch#11532 Pull Request resolved: #2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/ao#2339
This diff replace the debug handle with
from_nodeinfrastructure, which is a first class citizen in exported program and used to trace the node-level transformation. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle from from_node info via hasing.After this change user no longer need to invoke
generate_numeric_debug_handlefor debugging. Also the original pipeline will still work under current scenario.Reviewed By: jerryzh168
Differential Revision: D76168997