Skip to content

Define ET_HAS_EXCEPTIONS macro #11603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2025
Merged

Define ET_HAS_EXCEPTIONS macro #11603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bc8eec
Define ET_HAS_EXCEPTIONS macro
swolchok Jun 12, 2025
f713d4b
Update on "Define ET_HAS_EXCEPTIONS macro"
swolchok Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions runtime/platform/compiler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,14 @@
using ssize_t = ptrdiff_t;
#endif

#ifdef __EXCEPTIONS
#define ET_HAS_EXCEPTIONS 1
#elif defined(_HAS_EXCEPTIONS) && _HAS_EXCEPTIONS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious where do __EXCEPTIONS and _HAS_EXCEPTIONS come from?

Copy link
Contributor

@JacobSzwejbka JacobSzwejbka Jun 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh its in the test plan internally. From the compilers.

#define ET_HAS_EXCEPTIONS 1
#else
#define ET_HAS_EXCEPTIONS 0
#endif

// DEPRECATED: Use the non-underscore-prefixed versions instead.
// TODO(T199005537): Remove these once all users have stopped using them.
#define __ET_DEPRECATED ET_DEPRECATED
Expand Down
Loading