Skip to content

Return retained objects from Value constructors. #11632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
facebook-github-bot merged 1 commit into from
Jun 13, 2025
Merged

Return retained objects from Value constructors. #11632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions extension/apple/ExecuTorch/Exported/ExecuTorchValue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@ __attribute__((deprecated("This API is experimental.")))
* @param value An ExecuTorchTensor instance.
* @return A new ExecuTorchValue instance with a tag of ExecuTorchValueTagTensor.
*/
+ (instancetype)valueWithTensor:(ExecuTorchTensor *)value NS_REFINED_FOR_SWIFT;
+ (instancetype)valueWithTensor:(ExecuTorchTensor *)value
NS_REFINED_FOR_SWIFT
NS_RETURNS_RETAINED;

/**
* Creates an instance encapsulating a string.
Expand All @@ -182,7 +184,8 @@ __attribute__((deprecated("This API is experimental.")))
* @return A new ExecuTorchValue instance with a tag of ExecuTorchValueTagString.
*/
+ (instancetype)valueWithString:(ExecuTorchStringValue)value
NS_SWIFT_NAME(init(_:));
NS_SWIFT_NAME(init(_:))
NS_RETURNS_RETAINED;

/**
* Creates an instance encapsulating a boolean.
Expand All @@ -191,7 +194,8 @@ __attribute__((deprecated("This API is experimental.")))
* @return A new ExecuTorchValue instance with a tag of ExecuTorchValueTagBoolean.
*/
+ (instancetype)valueWithBoolean:(ExecuTorchBooleanValue)value
NS_SWIFT_NAME(init(_:));
NS_SWIFT_NAME(init(_:))
NS_RETURNS_RETAINED;

/**
* Creates an instance encapsulating an integer.
Expand All @@ -200,7 +204,8 @@ __attribute__((deprecated("This API is experimental.")))
* @return A new ExecuTorchValue instance with a tag of ExecuTorchValueTagInteger.
*/
+ (instancetype)valueWithInteger:(ExecuTorchIntegerValue)value
NS_SWIFT_NAME(init(_:));
NS_SWIFT_NAME(init(_:))
NS_RETURNS_RETAINED;

/**
* Creates an instance encapsulating a double value.
Expand All @@ -209,7 +214,8 @@ __attribute__((deprecated("This API is experimental.")))
* @return A new ExecuTorchValue instance with a tag of ExecuTorchValueTagDouble.
*/
+ (instancetype)valueWithDouble:(ExecuTorchDoubleValue)value
NS_SWIFT_NAME(init(_:));
NS_SWIFT_NAME(init(_:))
NS_RETURNS_RETAINED;

/**
* Creates an instance encapsulating a float value.
Expand All @@ -221,7 +227,8 @@ __attribute__((deprecated("This API is experimental.")))
* @return A new ExecuTorchValue instance with a tag of ExecuTorchValueTagDouble.
*/
+ (instancetype)valueWithFloat:(ExecuTorchFloatValue)value
NS_SWIFT_NAME(init(_:));
NS_SWIFT_NAME(init(_:))
NS_RETURNS_RETAINED;

/**
* Creates an instance encapsulating a scalar value.
Expand All @@ -232,7 +239,8 @@ __attribute__((deprecated("This API is experimental.")))
* @return A new ExecuTorchValue instance with the appropriate tag.
*/
+ (instancetype)valueWithScalar:(ExecuTorchScalarValue)value
NS_SWIFT_NAME(init(_:));
NS_SWIFT_NAME(init(_:))
NS_RETURNS_RETAINED;

/**
* Returns a copy of the value.
Expand Down
Loading