Arm backend: Add embedding.default + index_select #11636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GenAI used, Blackduck Scan OK, aten.embedding.default is requiring int64 indices which is not supported by TOSA. A pass is introduced to insert a int64->int32 cast. This enables aten.embedding to be decomposed into index_select, which can handle int32 indices and maps easier to TOSA. So support for aten.index_select is added as well, and for now it only supports [1, x, y] and [x, y] dimension inputs since that covers aten.embedding.default use case. In summary this patch adds: - One pass for inserting a cast, which is done very early since it needs to be rejected until TOSA supports int64 - One pass for decomposing aten.embedding - Mapping of index select to TOSA - Unit tests for above Change-Id: I6da17d6e2cf749b24bc1463a017eb8629de1810b
mansnils
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11636
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit 0b388ab with merge base d9b3cf4 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aten.embedding.default is requiring int64 indices which is not supported by TOSA. A pass is introduced to insert a int64->int32 cast. This enables aten.embedding to be decomposed into index_select, which can handle int32 indices and maps easier to TOSA. So support for aten.index_select is added as well, and for now it only supports [1, x, y] and [x, y] dimension inputs since that covers aten.embedding.default use case.
In summary this patch adds:
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218