[ET-VK][ez] Fix type ambiguity relating to TextureLimits class
#11642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context Fixes build failures in CI by resolving ambiguities with the `TextureLimits` class. ## Changes * Add converting constructor to construct `TextureLimits` from a `utils::uvec3` * Modify `UniformData` class to receive `utils::uvec3` directly, removing the need to reference `TextureLimits` Differential Revision: [D76608702](https://our.internmc.facebook.com/intern/diff/D76608702/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11642
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 PendingAs of commit 90fc268 with merge base d660bde ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
added a commit
that referenced
this pull request
Jun 13, 2025
## Context Fixes build failures in CI by resolving ambiguities with the `TextureLimits` class. ## Changes * Add converting constructor to construct `TextureLimits` from a `utils::uvec3` * Modify `UniformData` class to receive `utils::uvec3` directly, removing the need to reference `TextureLimits` Differential Revision: [D76608702](https://our.internmc.facebook.com/intern/diff/D76608702/) ghstack-source-id: 290281028 Pull Request resolved: #11642
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76608702 |
This PR needs a
|
JacobSzwejbka
approved these changes
Jun 13, 2025
manuelcandales
approved these changes
Jun 13, 2025
facebook-github-bot
merged commit 91a474a
into
gh/SS-JIA/242/base
96 of 99 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
JacobSzwejbka
pushed a commit
that referenced
this pull request
Jun 13, 2025
) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11642 by @SS-JIA ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/242/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/242/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/242/orig @diff-train-skip-merge Co-authored-by: Stephen Jia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
TextureLimitsclass #11642Context
Fixes build failures in CI by resolving ambiguities with the
TextureLimitsclass.Changes
TextureLimitsfrom autils::uvec3UniformDataclass to receiveutils::uvec3directly, removing the need to referenceTextureLimitsDifferential Revision: D76608702