-
Notifications
You must be signed in to change notification settings - Fork 712
[llm] Add sentencepiece tokenizer support to llm runner #11645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11645
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 9df5f1a with merge base a1dec07 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
jackzhxng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @kimishpatel said he had to make some additional changes on top of this to get it to work with Gemma3
Yep sync'ed with him will update the PR |
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Fixes pytorch/executorch#11618 Add sentencepiece tokenizer support X-link: pytorch/executorch#11645 Differential Revision: D76789606 Pulled By: larryliu0820
Summary: Fixes pytorch/executorch#11618 Add sentencepiece tokenizer support X-link: pytorch/executorch#11645 Differential Revision: D76789606 Pulled By: larryliu0820
|
This pull request was exported from Phabricator. Differential Revision: D76789606 |
Summary: X-link: meta-pytorch/tokenizers#85 Fixes #11618 Add sentencepiece tokenizer support Pull Request resolved: #11645 Differential Revision: D76789606 Pulled By: larryliu0820
9cf4b64 to
0c9f7f6
Compare
Summary: Pull Request resolved: #85 Fixes pytorch/executorch#11618 Add sentencepiece tokenizer support X-link: pytorch/executorch#11645 Differential Revision: D76789606 Pulled By: larryliu0820
guangy10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be added automatically to the apps, e.g. benchmark apps? Particular for iOS app, do we need to add the source to the project tree?
Summary: Fixes pytorch/executorch#11618 Add sentencepiece tokenizer support X-link: pytorch/executorch#11645 Reviewed By: guangy10 Differential Revision: D76789606 Pulled By: larryliu0820
Not sure, will check CI |
|
This pull request was exported from Phabricator. Differential Revision: D76789606 |
Summary: X-link: meta-pytorch/tokenizers#85 Fixes #11618 Add sentencepiece tokenizer support Pull Request resolved: #11645 Reviewed By: guangy10 Differential Revision: D76789606 Pulled By: larryliu0820
0c9f7f6 to
71e8288
Compare
Gemma-3 is disabled from running on the app. To check on CI, you can add gemma-3 back here:
|
Summary: Fixes pytorch/executorch#11618 Add sentencepiece tokenizer support X-link: pytorch/executorch#11645 Reviewed By: guangy10 Differential Revision: D76789606 Pulled By: larryliu0820
Summary: Fixes pytorch/executorch#11618 Add sentencepiece tokenizer support X-link: pytorch/executorch#11645 Reviewed By: guangy10 Differential Revision: D76789606 Pulled By: larryliu0820
Summary: Pull Request resolved: #85 Fixes pytorch/executorch#11618 Add sentencepiece tokenizer support X-link: pytorch/executorch#11645 Reviewed By: guangy10 Differential Revision: D76789606 Pulled By: larryliu0820
|
This pull request was exported from Phabricator. Differential Revision: D76789606 |
Summary: X-link: meta-pytorch/tokenizers#85 Fixes #11618 Add sentencepiece tokenizer support Pull Request resolved: #11645 Reviewed By: guangy10 Differential Revision: D76789606 Pulled By: larryliu0820
71e8288 to
a7b9512
Compare
|
do validate against hf tokenizer + model's output |
Summary: X-link: meta-pytorch/tokenizers#85 Fixes #11618 Add sentencepiece tokenizer support Pull Request resolved: #11645 Reviewed By: guangy10 Differential Revision: D76789606 Pulled By: larryliu0820
96fd3c2 to
cd8b708
Compare
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Fixes pytorch/executorch#11618 Add sentencepiece tokenizer support X-link: pytorch/executorch#11645 Reviewed By: guangy10 Differential Revision: D76789606 Pulled By: larryliu0820
Summary: Fixes pytorch/executorch#11618 Add sentencepiece tokenizer support X-link: pytorch/executorch#11645 Reviewed By: guangy10 Differential Revision: D76789606 Pulled By: larryliu0820
Summary: X-link: meta-pytorch/tokenizers#85 Fixes #11618 Add sentencepiece tokenizer support Pull Request resolved: #11645 Reviewed By: guangy10 Differential Revision: D76789606 Pulled By: larryliu0820
|
This pull request was exported from Phabricator. Differential Revision: D76789606 |
cd8b708 to
9df5f1a
Compare
Differential Revision: D76789606 Pull Request resolved: pytorch#11645
Fixes #11618
Add sentencepiece tokenizer support