Support Span to construct from a single element similar to ArrayRef #11757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the constructor from ArrayRef here https://github.com/pytorch/executorch/blob/5365c5559accc7a0d522eacdfb7385ce8914ef53/runtime/core/array_ref.h#L78-L81 so it's easier to use Differential Revision: [D76825662](https://our.internmc.facebook.com/intern/diff/D76825662/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11757
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9405f04 with merge base 1309849 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jun 13, 2025
|
This pull request was exported from Phabricator. Differential Revision: D76825662 |
… ArrayRef" Copy the constructor from ArrayRef here https://github.com/pytorch/executorch/blob/5365c5559accc7a0d522eacdfb7385ce8914ef53/runtime/core/array_ref.h#L78-L81 so it's easier to use exported-using-ghexport Differential Revision: [D76825662](https://our.internmc.facebook.com/intern/diff/D76825662/) Differential Revision: [D76825662](https://our.internmc.facebook.com/intern/diff/D76825662) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76825662 |
JacobSzwejbka
approved these changes
Jun 17, 2025
… ArrayRef" Copy the constructor from ArrayRef here https://github.com/pytorch/executorch/blob/5365c5559accc7a0d522eacdfb7385ce8914ef53/runtime/core/array_ref.h#L78-L81 so it's easier to use exported-using-ghexport Differential Revision: [D76825662](https://our.internmc.facebook.com/intern/diff/D76825662/) Differential Revision: [D76825662](https://our.internmc.facebook.com/intern/diff/D76825662) [ghstack-poisoned]
cccclai
added a commit
that referenced
this pull request
Jun 17, 2025
Pull Request resolved: #11757 Copy the constructor from ArrayRef here https://github.com/pytorch/executorch/blob/5365c5559accc7a0d522eacdfb7385ce8914ef53/runtime/core/array_ref.h#L78-L81 so it's easier to use ghstack-source-id: 291080862 @exported-using-ghexport Differential Revision: [D76825662](https://our.internmc.facebook.com/intern/diff/D76825662/)
|
This pull request was exported from Phabricator. Differential Revision: D76825662 |
… ArrayRef" Copy the constructor from ArrayRef here https://github.com/pytorch/executorch/blob/5365c5559accc7a0d522eacdfb7385ce8914ef53/runtime/core/array_ref.h#L78-L81 so it's easier to use exported-using-ghexport Differential Revision: [D76825662](https://our.internmc.facebook.com/intern/diff/D76825662/) Differential Revision: [D76825662](https://our.internmc.facebook.com/intern/diff/D76825662) [ghstack-poisoned]
cccclai
added a commit
that referenced
this pull request
Jun 17, 2025
Pull Request resolved: #11757 Copy the constructor from ArrayRef here https://github.com/pytorch/executorch/blob/5365c5559accc7a0d522eacdfb7385ce8914ef53/runtime/core/array_ref.h#L78-L81 so it's easier to use ghstack-source-id: 291106564 @exported-using-ghexport Differential Revision: [D76825662](https://our.internmc.facebook.com/intern/diff/D76825662/)
|
This pull request was exported from Phabricator. Differential Revision: D76825662 |
swolchok
added
the
release notes: api
facebook-github-bot
merged commit b4edff6
into
gh/cccclai/28/base
98 of 99 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
cccclai
added a commit
that referenced
this pull request
Jun 18, 2025
…11778) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11757 by @cccclai ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/cccclai/28/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/28/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/28/orig @diff-train-skip-merge Co-authored-by: Chen Lai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Copy the constructor from ArrayRef here
executorch/runtime/core/array_ref.h
Lines 78 to 81 in 5365c55
so it's easier to use
@exported-using-ghexport
Differential Revision: D76825662
Differential Revision: D76825662