Rename CMake target 'executorch' to 'prim_ops_lib' for clarity #11786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11786
Note: Links to docs will display an error until the docs builds have been completed. ❌ 218 New Failures, 2 Unrelated FailuresAs of commit d162123 with merge base ea4a7fa ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @JawadKhan65! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
@pytorchbot label "release notes: build" |
pytorch-bot
bot
added
the
release notes: build
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
@JawadKhan65 Sorry for the slow response - I know it's a bad look from the framework's perspective. I've triggered CI runs on the PR, and it looks like there are a few remaining tweaks needed. If we can get those resolved, I'll stamp and we can merge it. Thanks! |
|
Fixes #11761. |
|
@larryliu0820 changed |
|
Mind rebasing the patch? |
- Renamed executorch target to prim_ops_lib in CMakeLists.txt - Added executorch as an alias for backward compatibility - Updated executorch-config.cmake to use prim_ops_lib - Removed redundant manual target_link_options_shared_lib calls in examples - Updated documentation to reflect the new target name
…n up target_link_options_shared_lib, and update CMake as requested
JawadKhan65
force-pushed
the
rename-executorch-target
branch
from
2e09b42 to
c6643bc
Compare
Rebased on latest main and pushed. |
examples/models/llama/CMakeLists.txt
Outdated
| # llama_main: test binary to run llama, with tokenizer and sampler integrated | ||
| # | ||
|
|
||
| <<<<<<< HEAD |
examples/models/llama/CMakeLists.txt
Outdated
Comment on lines
87
to
91
| ======= | ||
| # find `executorch` libraries Same as for gflags | ||
| set(executorch_DIR ${CMAKE_CURRENT_BINARY_DIR}/../../../lib/cmake/ExecuTorch) | ||
| find_package(executorch CONFIG REQUIRED) | ||
| >>>>>>> 4bc106e7a5 (Rename CMake target 'executorch' to 'prim_ops_lib' for clarity) |
There was a problem hiding this comment.
Please fix the rebase
tools/cmake/executorch-config.cmake
Outdated
Comment on lines
51
to
58
| <<<<<<< HEAD | ||
| ======= | ||
|
|
||
| # If we reach here, ET required libraries are found. | ||
| target_link_libraries(executorch INTERFACE executorch_core) | ||
| target_link_options_shared_lib(prim_ops_lib) | ||
|
|
||
| >>>>>>> 2e09b42180 (Address larryliu0820 review comments: remove duplicate installs, clean up target_link_options_shared_lib, and update CMake as requested) |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
Hi @JawadKhan65 could you please fix the version control marker? we can retry the CI |
is it fine now? |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the CMake target
executorchtoprim_ops_libfor better clarity, as the name more accurately reflects its purpose as the library for primitive operations.Changes:
executorchtarget toprim_ops_libin root CMakeLists.txtadd_library(executorch ALIAS prim_ops_lib)for backward compatibilityexecutorch-config.cmaketo calltarget_link_options_shared_lib(prim_ops_lib)target_link_options_shared_libin examples and backends:Testing:
Benefits: