Skip to content

Qualcomm AI Engine Direct - support cli #11788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

Qualcomm AI Engine Direct - support cli #11788

merged 2 commits into from
Jun 26, 2025

Conversation

@haowhsu-quic
Copy link
Collaborator

@haowhsu-quic haowhsu-quic commented Jun 18, 2025 •
edited by pytorch-bot bot
Loading

Summary

  • add cli for quantize / compile / execute pipeline

Test plan

python backends/qualcomm/tests/test_qnn_delegate.py TestUtilsScript.test_cli -b build-android -s $device -m SM8750

cc @cccclai @winskuo-quic @shewu-quic @cbilgin

@haowhsu-quic haowhsu-quic requested a review from cccclai as a code owner June 18, 2025 16:09
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11788

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2e54936 with merge base 9c9f665 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@manuelcandales manuelcandales added the partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm label Jun 18, 2025
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cccclai
cccclai reviewed Jun 19, 2025
View reviewed changes
backends/qualcomm/qnn_preprocess.py
processed_bytes=node.meta[OpContextLoader.meta_ctx_bin],
debug_handle_map={},
)
return node.meta[OpContextLoader.meta_ctx_bin]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share the reason we need these changes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the path for loading pre-built context binary, I think it was broken before.

@cccclai
Copy link
Contributor

cccclai commented Jun 19, 2025

There are some CI failure, which I believe fixed in main. Can you rebase?

@cccclai
Copy link
Contributor

cccclai commented Jun 23, 2025

The lint is still failing https://github.com/pytorch/executorch/actions/runs/15769448844/job/44451660233?pr=11788

9e38c0b7e58436557263be486c982a7ed3cafaada51049d320316f7ab6eff97a
Running command: docker exec -t 9e38c0b7e584365572[63](https://github.com/pytorch/executorch/actions/runs/15769448844/job/44451660233?pr=11788#step:15:64)be486c982a7ed3cafaada51049d320316f7ab6eff97a /exec
++ '[' pull_request = pull_request ']'
++ echo aae0dba853b175b76a9cf114a14bf7a68f6cca84 ad8f91dcbacfcd15617fbdd6c4201218d4c72e4f
+ ./scripts/lint_xrefs.sh aae0dba853b175b76a9cf114a14bf7a68f6cca84 ad8f91dcbacfcd15617fbdd6c4201218d4c72e4f

examples/qualcomm/util_scripts/README.md:
FAIL ../../../../docs/source/backends-qualcomm.md#host-os

@haowhsu-quic
Qualcomm AI Engine Direct - support cli
26965a7 
- add cli for quantize / compile / execute pipeline
@haowhsu-quic
fix path error
2e54936
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai cccclai merged commit b809abc into pytorch:main Jun 26, 2025
103 of 104 checks passed
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
@haowhsu-quic @hinriksnaer
Qualcomm AI Engine Direct - support cli (pytorch#11788)
6fed744 
### Summary
- add cli for quantize / compile / execute pipeline

### Test plan
```bash
python backends/qualcomm/tests/test_qnn_delegate.py TestUtilsScript.test_cli -b build-android -s $device -m SM8750
```


cc @cccclai @winskuo-quic @shewu-quic @cbilgin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccclai cccclai cccclai approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@haowhsu-quic @facebook-github-bot @cccclai @manuelcandales