Skip to content

Conversation

@sdwilsh
Copy link

@sdwilsh sdwilsh commented Jun 18, 2025

Summary:
Add last_token_pos in the forward options.

Purpose:

  • the last norm and output of lm-head can be performed with the last valid token at prefill.
  • If the input sequence length is fixed when an accelerator doesn't support the dynamic shapes, selecting the last token from the input is not always guaranteed as valid.
  • Thus, it needs an additional pointer to select the last valid token only to perform the last norm and output.

Differential Revision: D76440105

Summary:
Add last_token_pos in the forward options.

Purpose:
* the last norm and output of lm-head can be performed with the last valid token at prefill.
* If the input sequence length is fixed when an accelerator doesn't support the dynamic shapes, selecting the last token from the input is not always guaranteed as valid.
* Thus, it needs an additional pointer to select the last valid token only to perform the last norm and output.

Differential Revision: D76440105
@sdwilsh sdwilsh requested review from jackzhxng and lucylq as code owners June 18, 2025 18:27
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11793

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit b526c43 with merge base 3c05b6c (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76440105

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

@JacobSzwejbka JacobSzwejbka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larryliu0820 any thoughts?

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76440105

@sdwilsh
Copy link
Author

sdwilsh commented Jul 3, 2025

I'm not the author of this code! Closing it...

@sdwilsh sdwilsh closed this Jul 3, 2025
jinook-song-meta added a commit to jinook-song-meta/executorch that referenced this pull request Jul 4, 2025
Summary:

Add last_token_pos in the forward options.

Purpose:
* the last norm and output of lm-head can be performed with the last valid token at prefill.
* If the input sequence length is fixed when an accelerator doesn't support the dynamic shapes, selecting the last token from the input is not always guaranteed as valid. 
* Thus, it needs an additional pointer to select the last valid token only to perform the last norm and output.

Reviewed By: JacobSzwejbka

Differential Revision: D76440105
facebook-github-bot pushed a commit that referenced this pull request Jul 8, 2025
Differential Revision: D76440105

Pull Request resolved: #12239
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
Differential Revision: D76440105

Pull Request resolved: pytorch#12239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants