Skip to content

Pull c10 headers directly from PyTorch internally, not from the c10 mirror #11800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Pull c10 headers directly from PyTorch internally, not from the c10 mirror #11800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 48 additions & 37 deletions runtime/core/portable_type/c10/c10/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,43 +49,6 @@ def define_common_targets():
The directory containing this targets.bzl file should also contain both
TARGETS and BUCK files that call this function.
"""
runtime.cxx_library(
name = "c10",
header_namespace = "c10",
exported_headers = [
"macros/Export.h",
"macros/Macros.h",
"util/BFloat16.h",
"util/BFloat16-inl.h",
"util/BFloat16-math.h",
"util/Half.h",
"util/Half-inl.h",
"util/TypeSafeSignMath.h",
"util/bit_cast.h",
"util/complex.h",
"util/complex_math.h",
"util/complex_utils.h",
"util/floating_point_utils.h",
"util/irange.h",
],
exported_preprocessor_flags = [
"-DC10_USING_CUSTOM_GENERATED_MACROS",
] + ([] if runtime.is_oss else [
"-DC10_USE_GLOG",
"-DC10_USE_MINIMAL_GLOG",
]),
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
deps = select({
"DEFAULT": [],
# Half-inl.h depends on vec_half.h from ATen, but only when building for x86.
"ovr_config//cpu:x86_64": [
":aten_headers_for_executorch",
],
}),
)

runtime.cxx_library(
name = "aten_headers_for_executorch",
Expand Down Expand Up @@ -118,3 +81,51 @@ def define_common_targets():
fbcode_exported_preprocessor_flags = get_preprocessor_flags(is_fbcode=True)
+ ([] if runtime.is_oss else ["-DET_USE_PYTORCH_HEADERS"]),
)

if runtime.is_oss:
runtime.cxx_library(
name = "c10",
header_namespace = "c10",
exported_headers = [
"macros/Export.h",
"macros/Macros.h",
"util/BFloat16.h",
"util/BFloat16-inl.h",
"util/BFloat16-math.h",
"util/Half.h",
"util/Half-inl.h",
"util/TypeSafeSignMath.h",
"util/bit_cast.h",
"util/complex.h",
"util/complex_math.h",
"util/complex_utils.h",
"util/floating_point_utils.h",
"util/irange.h",
],
exported_preprocessor_flags = [
"-DC10_USING_CUSTOM_GENERATED_MACROS",
] + ([] if runtime.is_oss else [
"-DC10_USE_GLOG",
"-DC10_USE_MINIMAL_GLOG",
]),
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
deps = select({
"DEFAULT": [],
# Half-inl.h depends on vec_half.h from ATen, but only when building for x86.
"ovr_config//cpu:x86_64": [
":aten_headers_for_executorch",
],
}),
)
else:
runtime.cxx_library(
name = "c10",
exported_deps = [":aten_headers_for_executorch"],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
)
Loading